Aura: Set focusable on textfield but not on location bar

Aura: Set focusable on textfield but not on location bar
Aura uses views textfield and needs to set focusable on omnibox instead of location bar.
 I used "views::Widget::IsPureViews" instead of ifdef because
this allow us to provide a flag to enable views textfield on widnows.

BUG=106632
TEST=BrowserFocusTest pass

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113709

[alicet1, 2011-12-07 22:16:12]

thanks oshima!

http://codereview.chromium.org/8832002/diff/11010/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

http://codereview.chromium.org/8832002/diff/11010/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/location_bar_view.cc:80: OmniboxViewViews*
AsViews(OmniboxView* view) {
is it better as a static conversion method on OmniboxViewViews or a member in
OmniboxView rather than here?

[sky, 2011-12-07 22:23:33]

http://codereview.chromium.org/8832002/diff/11010/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/location_bar_view.h (right):

http://codereview.chromium.org/8832002/diff/11010/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/location_bar_view.h:171: // Sets whether
the omnibox can accept focus.
We've generally used LocationEntry in this class when referring to the omnibox.
You should use LocationEntry here too. That said, I'm fine with Omnibox for the
name of these, but only if you rename everything to match. I suggest going with
LocationEntry and then in a follow on patch rename things. You'll want to make
sure Peter is fine with the renaming too.

[oshima, 2011-12-08 19:13:00]

http://codereview.chromium.org/8832002/diff/11010/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

http://codereview.chromium.org/8832002/diff/11010/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/location_bar_view.cc:80: OmniboxViewViews*
AsViews(OmniboxView* view) {
On 2011/12/07 22:16:13, alicet1 wrote:
> is it better as a static conversion method on OmniboxViewViews or a member in
> OmniboxView rather than here?

Only implementation needs this, and I prefer function in anonymous namespace
than private static function because it makes C++ header light weight.

http://codereview.chromium.org/8832002/diff/11010/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/location_bar_view.h (right):

http://codereview.chromium.org/8832002/diff/11010/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/location_bar_view.h:171: // Sets whether
the omnibox can accept focus.
On 2011/12/07 22:23:33, sky wrote:
> We've generally used LocationEntry in this class when referring to the
omnibox.
> You should use LocationEntry here too. That said, I'm fine with Omnibox for
the
> name of these, but only if you rename everything to match. I suggest going
with
> LocationEntry and then in a follow on patch rename things. You'll want to make
> sure Peter is fine with the renaming too.

Changed to LocationEntry.

[sky, 2011-12-08 20:10:33]

LGTM

[commit-bot: I haz the power, 2011-12-08 20:11:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8832002/22001

[commit-bot: I haz the power, 2011-12-08 21:41:58]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux_rel, revision is 113647, job name
was 8832002-22001 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).