Issue 8832001: Add an OWNERS file for the about:profiler javascript code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8832001: Add an OWNERS file for the about:profiler javascript code. (Closed)

Created:
9 years ago by eroman

Modified:
9 years ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add an OWNERS file for the about:profiler javascript code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113435

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2206 lines)			Patch
M	chrome/browser/browser_resources.grd	View		1 chunk	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/resources/profiler.html	View		1 chunk	+0 lines, -144 lines	0 comments	Download
D	chrome/browser/resources/profiler.js	View		1 chunk	+0 lines, -2062 lines	0 comments	Download
A	chrome/browser/resources/profiler/OWNERS	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	chrome/browser/resources/profiler/profiler.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/resources/profiler/profiler.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/ui/webui/profiler_ui.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

LGTM, but please make sure style reviews are going up to the resources/OWNERS file.

9 years ago (2011-12-07 18:44:38 UTC) #2

eroman

9 years ago (2011-12-07 18:58:18 UTC) #4

Actually if I need style approval for each change I submit in here, it kind of
defeats the purpose of having a separate OWNERS. (My motivation for that was so
I could commit these changes myself after getting reviewed by other guys working
on profiler).

We can chat via IM, hopefully I can just get approved as web-ui style capable
instead.

Expand Messages | Collapse Messages