Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8831005: Add null pointer checks to TestingProfile (Closed)

Created:
9 years ago by Timur Iskhodzhanov
Modified:
9 years ago
CC:
chromium-reviews, Paweł Hajdan Jr., Miranda Callahan, Scott Hess - ex-Googler
Visibility:
Public.

Description

Add null pointer checks to TestingProfile BUG=96010 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113429

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/test/base/testing_profile.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Timur Iskhodzhanov
9 years ago (2011-12-07 13:06:11 UTC) #1
Joao da Silva
lgtm. Paweł or another OWNER of chrome/test should stamp this.
9 years ago (2011-12-07 13:31:31 UTC) #2
Timur Iskhodzhanov
Hi chrome/tests OWNERS, can you please rubber-stamp this small CL? Thanks, Timur
9 years ago (2011-12-07 13:33:44 UTC) #3
Scott Hess - ex-Googler
lgtm, but i don't think i'm an owner, either.
9 years ago (2011-12-07 15:51:35 UTC) #4
sky
LGTM
9 years ago (2011-12-07 16:51:44 UTC) #5
Timur Iskhodzhanov
Thanks! Joao, prepare for landing :)
9 years ago (2011-12-07 17:00:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timurrrr@chromium.org/8831005/3001
9 years ago (2011-12-07 17:01:15 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-07 19:00:44 UTC) #8 
Change committed as 113429

Powered by Google App Engine
This is Rietveld 408576698