Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8831001: base::Bind: Convert Socket::Write. (Closed)

Created:
9 years ago by James Hawkins
Modified:
9 years ago
Reviewers:
csilv
CC:
chromium-reviews, jamiewalch+watch_chromium.org, garykac+watch_chromium.org, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., sergeyu+watch_chromium.org
Visibility:
Public.

Description

base::Bind: Convert Socket::Write. BUG=none TEST=none R=csilv Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113699

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix alignment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1060 lines, -170 lines) Patch
M content/browser/renderer_host/p2p/socket_host_test_utils.h View 2 chunks +11 lines, -0 lines 0 comments Download
M jingle/glue/channel_socket_adapter.h View 2 chunks +4 lines, -1 line 0 comments Download
M jingle/glue/channel_socket_adapter.cc View 4 chunks +59 lines, -11 lines 0 comments Download
M jingle/glue/pseudotcp_adapter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M jingle/glue/pseudotcp_adapter.cc View 9 chunks +55 lines, -12 lines 0 comments Download
M jingle/glue/pseudotcp_adapter_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M jingle/notifier/base/fake_ssl_client_socket.h View 1 chunk +2 lines, -0 lines 0 comments Download
M jingle/notifier/base/fake_ssl_client_socket.cc View 1 chunk +7 lines, -1 line 0 comments Download
M jingle/notifier/base/fake_ssl_client_socket_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M jingle/notifier/base/proxy_resolving_client_socket.h View 1 chunk +2 lines, -0 lines 0 comments Download
M jingle/notifier/base/proxy_resolving_client_socket.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M net/curvecp/curvecp_client_socket.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/curvecp/curvecp_client_socket.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/curvecp/curvecp_server_socket.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/curvecp/curvecp_server_socket.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/curvecp/messenger.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/curvecp/messenger.cc View 3 chunks +34 lines, -7 lines 0 comments Download
M net/http/http_proxy_client_socket.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_proxy_client_socket.cc View 1 chunk +8 lines, -1 line 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M net/socket/socket.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/socket/socket_test_util.h View 6 chunks +14 lines, -3 lines 0 comments Download
M net/socket/socket_test_util.cc View 7 chunks +93 lines, -26 lines 0 comments Download
M net/socket/socks5_client_socket.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/socket/socks5_client_socket.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M net/socket/socks_client_socket.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/socket/socks_client_socket.cc View 1 chunk +9 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_mac.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_mac.cc View 3 chunks +34 lines, -8 lines 0 comments Download
M net/socket/ssl_client_socket_nss.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 6 chunks +49 lines, -12 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.h View 2 chunks +6 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 4 chunks +33 lines, -7 lines 0 comments Download
M net/socket/ssl_client_socket_win.h View 2 chunks +6 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_win.cc View 3 chunks +38 lines, -8 lines 0 comments Download
M net/socket/ssl_server_socket_nss.h View 2 chunks +4 lines, -1 line 0 comments Download
M net/socket/ssl_server_socket_nss.cc View 1 3 chunks +35 lines, -8 lines 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M net/socket/tcp_client_socket_libevent.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/socket/tcp_client_socket_libevent.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M net/socket/tcp_client_socket_win.h View 2 chunks +6 lines, -2 lines 0 comments Download
M net/socket/tcp_client_socket_win.cc View 3 chunks +65 lines, -7 lines 0 comments Download
M net/socket/transport_client_socket_pool_unittest.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M net/socket/web_socket_server_socket.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M net/socket/web_socket_server_socket_unittest.cc View 2 chunks +23 lines, -1 line 0 comments Download
M net/spdy/spdy_proxy_client_socket.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/spdy/spdy_proxy_client_socket.cc View 7 chunks +62 lines, -11 lines 0 comments Download
M net/udp/udp_client_socket.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/udp/udp_client_socket.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/udp/udp_socket_libevent.h View 4 chunks +8 lines, -2 lines 0 comments Download
M net/udp/udp_socket_libevent.cc View 6 chunks +51 lines, -7 lines 0 comments Download
M net/udp/udp_socket_win.h View 3 chunks +7 lines, -1 line 0 comments Download
M net/udp/udp_socket_win.cc View 1 6 chunks +40 lines, -7 lines 0 comments Download
M remoting/jingle_glue/ssl_socket_adapter.h View 2 chunks +4 lines, -1 line 0 comments Download
M remoting/jingle_glue/ssl_socket_adapter.cc View 5 chunks +30 lines, -6 lines 0 comments Download
M remoting/protocol/fake_session.h View 2 chunks +4 lines, -0 lines 0 comments Download
M remoting/protocol/fake_session.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M remoting/protocol/pepper_transport_socket_adapter.h View 2 chunks +4 lines, -1 line 0 comments Download
M remoting/protocol/pepper_transport_socket_adapter.cc View 3 chunks +35 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
James Hawkins
9 years ago (2011-12-07 02:55:03 UTC) #1
csilv
lgtm http://codereview.chromium.org/8831001/diff/1/net/socket/ssl_server_socket_nss.cc File net/socket/ssl_server_socket_nss.cc (right): http://codereview.chromium.org/8831001/diff/1/net/socket/ssl_server_socket_nss.cc#newcode797 net/socket/ssl_server_socket_nss.cc:797: c.Run(rv); nit: fix alignment
9 years ago (2011-12-07 20:45:22 UTC) #2
James Hawkins
9 years ago (2011-12-08 23:50:46 UTC) #3 
http://codereview.chromium.org/8831001/diff/1/net/socket/ssl_server_socket_ns...
File net/socket/ssl_server_socket_nss.cc (right):

http://codereview.chromium.org/8831001/diff/1/net/socket/ssl_server_socket_ns...
net/socket/ssl_server_socket_nss.cc:797: c.Run(rv);
On 2011/12/07 20:45:22, csilv wrote:
> nit: fix alignment

Done.

Powered by Google App Engine
This is Rietveld 408576698