Pass table entry to rename and delete callbacks,

remoting/webapp/me2mom/host_list.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class representing the host-list portion of the home screen UI.
  */
 
 'use strict';
@@ skipping 99 matching lines @@
  * Refresh the host list with up-to-date details.
  * @param {Array.<remoting.Host>} hosts The new host list.
  * @return {void} Nothing.
  * @private
  */
 remoting.HostList.prototype.setHosts_ = function(hosts) {
   this.table_.innerHTML = '';
   this.showError_(null);
   this.hostTableEntries_ = [];
 
-  /** @type {remoting.HostList} */
+  /**
+   * @type {remoting.HostList}
+   */
   var that = this;
+  /**
+   * @param {remoting.HostTableEntry} hostTableEntry The entry being renamed.
+   */
+  var onRename = function(hostTableEntry) { that.renameHost_(hostTableEntry); }
+  /**
+   * @param {remoting.HostTableEntry} hostTableEntry The entry beign deleted.
+   */
+  var onDelete = function(hostTableEntry) { that.deleteHost_(hostTableEntry); }
+
   for (var i = 0; i < hosts.length; ++i) {
     /** @type {remoting.Host} */
     var host = hosts[i];
     // Validate the entry to make sure it has all the fields we expect.
     if (host.hostName && host.hostId && host.status && host.jabberId &&
         host.publicKey) {
-      var onRename = function() { that.renameHost_(host.hostId); }
-      var onDelete = function() { that.deleteHost_(host.hostId); }
       var hostTableEntry = new remoting.HostTableEntry();
       hostTableEntry.init(host, onRename, onDelete);
       this.hostTableEntries_[i] = hostTableEntry;
       this.table_.appendChild(hostTableEntry.tableRow);
     }
   }
 
   this.showOrHide_(this.hostTableEntries_.length != 0);
 };
 
@@ skipping 26 matching lines @@
   if (show) {
     parent.style.height = parent.scrollHeight + 'px';
     removeClass(parent, remoting.HostList.COLLAPSED_);
   } else {
     addClass(parent, remoting.HostList.COLLAPSED_);
   }
 };
 
 /**
  * Remove a host from the list, and deregister it.
- * @param {string} hostId The id of the host to be removed.
+ * @param {remoting.HostTableEntry} hostTableEntry The host to be removed.
  * @return {void} Nothing.
  * @private
  */
-remoting.HostList.prototype.deleteHost_ = function(hostId) {
-  /** @type {remoting.HostTableEntry} */
-  var hostTableEntry = this.getHostForId(hostId);
-  if (!hostTableEntry) {
-    console.error('No host registered for id ' + hostId);
-    return;
-  }
-
+remoting.HostList.prototype.deleteHost_ = function(hostTableEntry) {
   this.table_.removeChild(hostTableEntry.tableRow);
   var index = this.hostTableEntries_.indexOf(hostTableEntry);
-  if (index != -1) {  // Since we've just found it, index must be >= 0
+  if (index != -1) {
     this.hostTableEntries_.splice(index, 1);
   }
 
   /** @param {string} token */
   var deleteHost = function(token) {
     var headers = { 'Authorization': 'OAuth ' + token };
     remoting.xhr.remove(
-        'https://www.googleapis.com/chromoting/v1/@me/hosts/' + hostId,
+        'https://www.googleapis.com/chromoting/v1/@me/hosts/' +
+        hostTableEntry.host.hostId,
         function() {}, '', headers);
   }
   remoting.oauth2.callWithToken(deleteHost);
 
   this.showOrHide_(this.hostTableEntries_.length != 0);
 };
 
 /**
  * Prepare a host for renaming by replacing its name with an edit box.
- * @param {string} hostId The id of the host to be renamed.
+ * @param {remoting.HostTableEntry} hostTableEntry The host to be renamed.
  * @return {void} Nothing.
  * @private
  */
-remoting.HostList.prototype.renameHost_ = function(hostId) {
-  /** @type {remoting.HostTableEntry} */
-  var hostTableEntry = this.getHostForId(hostId);
-  if (!hostTableEntry) {
-    console.error('No host registered for id ' + hostId);
-    return;
-  }
+remoting.HostList.prototype.renameHost_ = function(hostTableEntry) {
   /** @param {string} token */
   var renameHost = function(token) {
     var headers = {
       'Authorization': 'OAuth ' + token,
       'Content-type' : 'application/json; charset=UTF-8'
     };
     var newHostDetails = { data: {
       hostId: hostTableEntry.host.hostId,
       hostName: hostTableEntry.host.hostName,
       publicKey: hostTableEntry.host.publicKey
     } };
     remoting.xhr.put(
-        'https://www.googleapis.com/chromoting/v1/@me/hosts/' + hostId,
+        'https://www.googleapis.com/chromoting/v1/@me/hosts/' +
+        hostTableEntry.host.hostId,
         function(xhr) {},
         JSON.stringify(newHostDetails),
         headers);
   }
   remoting.oauth2.callWithToken(renameHost);
 };
 
 /**
  * Class name for the host list when it is collapsed.
  * @private
  */
 remoting.HostList.COLLAPSED_ = 'collapsed';
 
 /** @type {remoting.HostList} */
 remoting.hostList = null;