Issue 8830001: Pass table entry to rename and delete callbacks,

Issue 8830001: Pass table entry to rename and delete callbacks, (Closed)

Created:
9 years ago by Jamie

Modified:
9 years ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pass table entry to rename and delete callbacks, since closures don't work the way I thought they did. BUG=106421 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113917

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review #

Patch Set 3 : Rebase #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -34 lines)			Patch
	M	remoting/webapp/me2mom/host_list.js	View		5 chunks	+21 lines, -23 lines	0 comments	Download
	M	remoting/webapp/me2mom/host_table_entry.js	View	1	3 chunks	+13 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Wez

lgtm http://codereview.chromium.org/8830001/diff/1/remoting/webapp/me2mom/host_table_entry.js File remoting/webapp/me2mom/host_table_entry.js (right): http://codereview.chromium.org/8830001/diff/1/remoting/webapp/me2mom/host_table_entry.js#newcode46 remoting/webapp/me2mom/host_table_entry.js:46: this.onRename_ = function(hostId) {}; nit: In future both ...

9 years ago (2011-12-09 22:54:40 UTC) #2

Jamie

http://codereview.chromium.org/8830001/diff/1/remoting/webapp/me2mom/host_table_entry.js File remoting/webapp/me2mom/host_table_entry.js (right): http://codereview.chromium.org/8830001/diff/1/remoting/webapp/me2mom/host_table_entry.js#newcode46 remoting/webapp/me2mom/host_table_entry.js:46: this.onRename_ = function(hostId) {}; On 2011/12/09 22:54:41, Wez wrote: ...

9 years ago (2011-12-09 23:52:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/8830001/5002

9 years ago (2011-12-09 23:59:57 UTC) #4

Change committed as 113917

Expand Messages | Collapse Messages