Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 8828010: mac: s/UINT32_MAX/kuint32max/ (Closed)

Created:
9 years ago by Nico
Modified:
8 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

mac: s/UINT32_MAX/kuint32max/ Needed to build on 10.5, which is in turn needed for coverity. BUG=none TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/base/x509_certificate_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nico
9 years ago (2011-12-07 00:37:31 UTC) #1
Ryan Sleevi
LGTM, but you'll need to get a net/ OWNERs to rubberstamp or TBR it.
9 years ago (2011-12-07 00:43:40 UTC) #2
willchan no longer on Chromium
LGTM On Tue, Dec 6, 2011 at 4:43 PM, <rsleevi@chromium.org> wrote: > LGTM, but you'll ...
9 years ago (2011-12-07 00:45:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8828010/1
9 years ago (2011-12-07 00:45:49 UTC) #4
commit-bot: I haz the power
Commit queue had an internal error. Something went really wrong, probably a crash, a hickup ...
9 years ago (2011-12-07 02:51:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8828010/1
9 years ago (2011-12-07 02:52:56 UTC) #6
commit-bot: I haz the power
Can't apply patch for file net/base/x509_certificate_mac.cc. While running patch -p1 --forward --force; patching file net/base/x509_certificate_mac.cc ...
9 years ago (2011-12-07 02:52:57 UTC) #7
ramant (doing other things)
looks like commit-bot failed to commit. Should we consider manually committing or give commit-bot one ...
8 years, 10 months ago (2012-02-14 04:56:21 UTC) #8
Nico
8 years, 10 months ago (2012-02-14 16:16:19 UTC) #9
Looks like the change did make it into the file somehow. Maybe I committed this
manually, I don't remember. Closing this issue.

Powered by Google App Engine
This is Rietveld 408576698