Implement two-argument check inline cache.

vm/code_generator_ia32.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_CODE_GENERATOR_IA32_H_
 #define VM_CODE_GENERATOR_IA32_H_
 
 #ifndef VM_CODE_GENERATOR_H_
 #error Do not include code_generator_ia32.h directly; use code_generator.h.
 #endif
@@ skipping 152 matching lines @@
                                 const String& field_name);
   void GenerateLoadIndexed(intptr_t node_id, intptr_t token_index);
   void GenerateStoreIndexed(intptr_t node_id,
                             intptr_t token_index,
                             bool preserve_value);
 
   void GenerateInstanceCall(intptr_t node_id,
                             intptr_t token_index,
                             const String& function_name,
                             int num_arguments,
-                            const Array& optional_arguments_names);
+                            const Array& optional_arguments_names,
+                            intptr_t num_checks);

[regis, 2011/12/09 23:08:03]

Would it be possible to spare this additional argument and derive it from
function_name and num_arguments?

The name "num_checks" does not say much. What kind of checks?

[srdjan, 2011/12/12 17:19:33]

num_checks -> num_args_checked, added comment as well.

I do no think that is simple to derive num_args_checked from the function_name
and num_arguments. It seems more reliable if that knowledge is embedded in the
appropriate visitor method.

 
   void GenerateInstanceOf(intptr_t node_id,
                           intptr_t token_index,
                           const AbstractType& type,
                           bool negate_result);
   void GenerateAssertAssignable(intptr_t node_id,
                                 intptr_t token_index,
                                 const AbstractType& dst_type,
                                 const String& dst_name);
   void GenerateArgumentTypeChecks();
@@ skipping 34 matching lines @@
   HandlerList* exception_handlers_list_;
   int try_index_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(CodeGenerator);
 };
 
 
 }  // namespace dart
 
 #endif  // VM_CODE_GENERATOR_IA32_H_