Move/replace/rename URL-based extension getters from ExtensionService to/in ExtensionSet.

chrome/browser/memory_details.cc

Index: chrome/browser/memory_details.cc
diff --git a/chrome/browser/memory_details.cc b/chrome/browser/memory_details.cc
index c06ed53ede94dc111ce5231eb72cb4ea5192f4b3..583e6809690d6d59583facaf97979a4afc84fc92 100644
--- a/chrome/browser/memory_details.cc
+++ b/chrome/browser/memory_details.cc
@@ -232,8 +232,8 @@ void MemoryDetails::CollectChildInfoOnUIThread() {
         TabContents* contents = host_delegate->GetAsTabContents();
         if (!contents) {
           if (extension_process_map->Contains(host->process()->GetID())) {
-            const Extension* extension =
-                extension_service->GetExtensionByURL(url);
+            const Extension* extension = extension_service->extensions()->

[Aaron Boodman, 2011/12/09 16:05:20]

This doesn't seem like the right wrapping style to me. Shouldn't
'extension_service' go on a new line? I saw this in another place earlier and
forgot to comment.

[Yoyo Zhou, 2011/12/09 19:59:09]

Done.

+                GetByURL(ExtensionURLInfo(url));

[Aaron Boodman, 2011/12/09 16:05:20]

This changes the behavior. Previously it would only find extensions and packaged
apps here.

[Yoyo Zhou, 2011/12/09 19:59:09]

Arg. I did look at all of these carefully and my conclusion for this one was
inconclusive. I can't follow the logic in this function completely, but it looks
like this does cause a regression in about:memory.

I added a check to return to the old behavior and it seems fine now.

             if (extension) {
               string16 title = UTF8ToUTF16(extension->name());
               process.titles.push_back(title);