chrome/browser/renderer_host/chrome_render_view_host_observer.cc - Issue 8827013: Move/replace/rename URL-based extension getters from ExtensionService to/in ExtensionSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_render_view_host_observer.cc

Issue 8827013: Move/replace/rename URL-based extension getters from ExtensionService to/in ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: extent Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/desktop_notification_service.cc ('K') | « chrome/browser/notifications/notification_options_menu_model.cc ('k') | chrome/browser/tab_contents/render_view_host_delegate_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/chrome_render_view_host_observer.cc

diff --git a/chrome/browser/renderer_host/chrome_render_view_host_observer.cc b/chrome/browser/renderer_host/chrome_render_view_host_observer.cc

index 6ce517d6fa845629f7ea38b6056b13b63b7cbb27..dc80f0ff1362fcd394cb504c2677527aed10e47b 100644

--- a/chrome/browser/renderer_host/chrome_render_view_host_observer.cc

+++ b/chrome/browser/renderer_host/chrome_render_view_host_observer.cc

@@ -152,7 +152,7 @@ const Extension* ChromeRenderViewHostObserver::GetExtension() {

// May be null if the extension doesn't exist, for example if somebody typos

// a chrome-extension:// URL.

- return service->GetExtensionByURL(site);

+ return service->extensions()->GetByURL(ExtensionURLInfo(site));

abarth-chromium 2011/12/07 23:51:44 Same here.

Yoyo Zhou 2011/12/08 20:52:17 I can't find any evidence that a SiteInstance migh

}

void ChromeRenderViewHostObserver::RemoveRenderViewHostForExtensions(