chrome/browser/extensions/extension_function_dispatcher.cc - Issue 8827013: Move/replace/rename URL-based extension getters from ExtensionService to/in ExtensionSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_function_dispatcher.cc

Issue 8827013: Move/replace/rename URL-based extension getters from ExtensionService to/in ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: extent Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_chrome_auth_private_api.cc ('k') | chrome/browser/extensions/extension_navigation_observer.cc » ('j') | chrome/browser/geolocation/chrome_geolocation_permission_context.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_function_dispatcher.cc

diff --git a/chrome/browser/extensions/extension_function_dispatcher.cc b/chrome/browser/extensions/extension_function_dispatcher.cc

index c5891bee75754587e7bf3768d5e66b74ff4b4689..da5bbb457aa201fee2ad7d177b74c8c8f0fed0b6 100644

--- a/chrome/browser/extensions/extension_function_dispatcher.cc

+++ b/chrome/browser/extensions/extension_function_dispatcher.cc

@@ -610,7 +610,7 @@ void ExtensionFunctionDispatcher::Dispatch(

const Extension* extension = service->GetExtensionById(

params.extension_id, false);

if (!extension)

- extension = service->GetExtensionByWebExtent(params.source_url);

+ extension = service->extensions()->GetByWebExtent(params.source_url);

abarth-chromium 2011/12/07 23:51:44 Ideally we'd have the SecurityOrigin here as well

Yoyo Zhou 2011/12/09 00:18:55 Done.

scoped_refptr<ExtensionFunction> function(

CreateExtensionFunction(params, extension,