Issue 8827012: Some visual tweaks to the virtual keyboard.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8827012: Some visual tweaks to the virtual keyboard. (Closed)

Created:
9 years ago by bryeung%chromium.org

Modified:
9 years ago

Reviewers:
mazda, bryeung

CC:
chromium-reviews, arv (Not doing code reviews), yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Some visual tweaks to the virtual keyboard. BUG=none TEST=manually

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	chrome/browser/resources/keyboard/main.css	View		4 chunks	+5 lines, -2 lines	1 comment	Download
	A	chrome/browser/resources/keyboard/shift-down.svg	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bryeung

I wanted to use this as the base image for a prototype I'm working on, ...

9 years ago (2011-12-06 23:17:50 UTC) #1

mazda

9 years ago (2011-12-07 01:04:06 UTC) #2

LGTM with a nit.

http://codereview.chromium.org/8827012/diff/1/chrome/browser/resources/keyboa...
File chrome/browser/resources/keyboard/main.css (right):

http://codereview.chromium.org/8827012/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/main.css:9: background-repeat: no-repeat;
nit: This can be merged into the previous line.

background: -webkit-linear-gradient(#bababa, #868686) no-repeat;

Expand Messages | Collapse Messages