Panel strip refactor cleanup.

chrome/browser/ui/panels/panel.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_H_
 #define CHROME_BROWSER_UI_PANELS_PANEL_H_
 #pragma once
 
 #include "chrome/browser/ui/browser_window.h"
 
@@ skipping 40 matching lines @@
 
   // Returns the PanelManager associated with this panel.
   PanelManager* manager() const;
 
   // Gets the extension that a panel is created from.
   // Returns NULL if it cannot be found.
   const Extension* GetExtension() const;
 
   void SetExpansionState(ExpansionState new_expansion_state);
 
-  bool ShouldBringUpTitlebar(int mouse_x, int mouse_y) const;
-
   bool IsDrawingAttention() const;
 
   // This function will only get called by PanelManager when full screen mode
   // changes i.e it gets called when an app goes into full screen mode or when
   // an app exits full screen mode. Panel should respond by making sure
   // a) it does not go on top when some app enters full screen mode.
   // b) it remains on top when an app exits full screen mode.
   void FullScreenModeChanged(bool is_full_screen);
 
-  void MoveOutOfOverflow();
-
   // Ensures that the panel is fully visible, that is, not obscured by other
   // top-most windows.
   void EnsureFullyVisible();
 
   int TitleOnlyHeight() const;
 
   // Returns the size of the panel when it is iconified, as shown on the
   // overflow area.
   gfx::Size IconOnlySize() const;
 
@@ skipping 157 matching lines @@
 
   // Updates the panel bounds instantly without any animation.
   void SetPanelBoundsInstantly(const gfx::Rect& bounds);
 
   // Sets whether the panel will auto resize according to its content.
   void SetAutoResizable(bool resizable);
 
   // Sets minimum and maximum size for the panel.
   void SetSizeRange(const gfx::Size& min_size, const gfx::Size& max_size);
 
+  // Sets whether the panel app icon is visible in the taskbar.
+  void SetAppIconVisibility(bool visible);
+
+  // Newly created panels may be placed in a temporary layout until their
+  // final position is determined.
+  bool temporary_layout() const { return temporary_layout_; }
+  void set_temporary_layout(bool temporary) { temporary_layout_ = temporary; }
+
  protected:
   virtual void DestroyBrowser() OVERRIDE;
 
  private:
   friend class PanelManager;
   friend class PanelBrowserTest;
   FRIEND_TEST_ALL_PREFIXES(PanelBrowserTest, RestoredBounds);
 
   // Panel can only be created using PanelManager::CreatePanel().
   // |requested_size| is the desired size for the panel, but actual
   // size may differ after panel layout.
   Panel(Browser* browser, const gfx::Size& requested_size);
 
   // Configures the tab contents for auto resize, including configurations
   // on the renderer and detecting renderer changes.
   void EnableTabContentsAutoResize(TabContents* tab_contents);
 
   // Configures the renderer for auto resize (if auto resize is enabled).
   void ConfigureAutoResize(TabContents* tab_contents);
 
   Browser* browser_;  // Weak, owned by native panel.
 
   bool initialized_;
 
+  // Newly created panels may be placed in a temporary layout until their
+  // final position is determined.
+  bool temporary_layout_;

[jianli, 2011/12/07 22:13:26]

Probably better to say has_temporary_layout_. The name "temporary_layout_" makes
me think this stores the temporary layout info, instead of a boolean flag. Or,
maybe we can call it as layout_finalized_.

[jennb, 2011/12/07 23:35:40]

Done.

+
   // Stores the full size of the panel so we can restore it after it's
   // been minimized.
   gfx::Size restored_size_;
 
   // This is the minimum size that the panel can shrink to.
   gfx::Size min_size_;
 
   // This is the size beyond which the panel is not going to grow to accomodate
   // the growing content and WebKit would add the scrollbars in such case.
   gfx::Size max_size_;
 
   // True if this panel auto resizes based on content.
   bool auto_resizable_;
 
   // Platform specifc implementation for panels.  It'd be one of
   // PanelBrowserWindowGtk/PanelBrowserView/PanelBrowserWindowCocoa.
   NativePanel* native_panel_;  // Weak, owns us.
 
   ExpansionState expansion_state_;
 
+  // Indicates whether the panel app icon is visible in the taskbar.
+  bool app_icon_visible_;
+
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(Panel);
 };
 
 #endif  // CHROME_BROWSER_UI_PANELS_PANEL_H_