Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 8827008: Fixed failing sdk_update_test on NaCl SDK bots (Closed)

Created:
9 years ago by mball
Modified:
9 years ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Fixed failing sdk_update_test on NaCl SDK bots BUG=None TEST=None TBR=bradnelson, noelallen

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M native_client_sdk/src/build_tools/tests/sdk_update_test.py View 6 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Matt Ball
Forgot to update sdk_update_test after the previous change...
9 years ago (2011-12-06 22:25:42 UTC) #1
bradn
lgtm
9 years ago (2011-12-06 22:37:57 UTC) #2
Matt Ball
Looks like that picky OWNERS file is complaining about the google.comdomain again. Is there anything ...
9 years ago (2011-12-07 00:11:32 UTC) #3
noelallen1
Since the code is now in the chrome repo, you should probably use a Chromium ...
9 years ago (2011-12-07 00:22:59 UTC) #4
Matt Ball
On 2011/12/07 00:22:59, noelallen1 wrote: > Since the code is now in the chrome repo, ...
9 years ago (2011-12-07 00:24:36 UTC) #5
Matt Ball
Brad or Noel: Could one of you provide approval from your chromium.org account? Thanks!
9 years ago (2011-12-07 00:45:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mball@chromium.org/8827008/1
9 years ago (2011-12-07 13:07:56 UTC) #7
commit-bot: I haz the power
Presubmit check for 8827008-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-07 13:07:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mball@chromium.org/8827008/1
9 years ago (2011-12-07 13:10:28 UTC) #9
commit-bot: I haz the power
Presubmit check for 8827008-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-07 13:10:30 UTC) #10
Matt Ball
9 years ago (2011-12-07 14:54:30 UTC) #11
Committed TBR as r113390

Powered by Google App Engine
This is Rietveld 408576698