Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 8827005: Revert 113250 - Add CommandBuffer::SetGetBuffer (Closed)

Created:
9 years ago by dglazkov
Modified:
9 years ago
Reviewers:
greggman
CC:
chromium-reviews, jam, yzshen+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, apatrick_chromium, Paweł Hajdan Jr., piman+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Revert 113250 - Add CommandBuffer::SetGetBuffer As well as remove CommandBuffer::GetRingBuffer and change CommandBuffer::Initialize Before this change the service allocated and managed the command buffer. After this change the client uses CreateTransferBuffer, GetTransferBuffer, end potentially DeleteTransferBufffer to manage the command buffer. Another CL will actually make the client delete the command buffer on demand. TEST=unit tests and run some samples and a NaCl 3D game BUG=103989 Review URL: http://codereview.chromium.org/8566059 TBR=gman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+541 lines, -485 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 4 chunks +15 lines, -9 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +3 lines, -5 lines 0 comments Download
M content/renderer/gpu/command_buffer_proxy.h View 2 chunks +7 lines, -2 lines 0 comments Download
M content/renderer/gpu/command_buffer_proxy.cc View 4 chunks +62 lines, -10 lines 0 comments Download
M content/renderer/gpu/renderer_gl_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper.h View 2 chunks +1 line, -9 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper.cc View 3 chunks +3 lines, -21 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper_test.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/fenced_allocator_test.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 39 chunks +101 lines, -134 lines 0 comments Download
M gpu/command_buffer/client/mapped_memory_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/ring_buffer_test.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/common/command_buffer.h View 2 chunks +7 lines, -5 lines 0 comments Download
M gpu/command_buffer/common/command_buffer_mock.h View 1 chunk +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/command_buffer_mock.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/cmd_buffer_engine.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/cmd_parser.h View 2 chunks +8 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/cmd_parser.cc View 1 chunk +10 lines, -16 lines 0 comments Download
M gpu/command_buffer/service/cmd_parser_test.cc View 2 chunks +6 lines, -34 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service.cc View 4 chunks +57 lines, -22 lines 0 comments Download
M gpu/command_buffer/service/common_decoder_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.cc View 2 chunks +15 lines, -23 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler_unittest.cc View 7 chunks +19 lines, -32 lines 0 comments Download
M gpu/demos/framework/window.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/trusted/ppb_graphics_3d_trusted.h View 1 chunk +5 lines, -3 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc View 1 chunk +20 lines, -6 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/command_buffer_nacl.h View 1 chunk +6 lines, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/command_buffer_nacl.cc View 2 chunks +22 lines, -9 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_graphics_3d.srpc View 2 chunks +8 lines, -7 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_server.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/trusted/srpcgen/ppb_rpc.h View 1 chunk +4 lines, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppb_rpc.h View 1 chunk +4 lines, -2 lines 0 comments Download
MM ppapi/proxy/ppapi_messages.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.cc View 8 chunks +62 lines, -27 lines 0 comments Download
M ppapi/thunk/ppb_graphics_3d_api.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_graphics_3d_trusted_thunk.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.cc View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dglazkov
9 years ago (2011-12-06 20:21:14 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698