frog/gen.dart - Issue 8826014: frog: generalize checking that type args aren't used in static methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/gen.dart

Issue 8826014: frog: generalize checking that type args aren't used in static methods (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: frog/gen.dart

diff --git a/frog/gen.dart b/frog/gen.dart

index ceb3b403d573fa0f8ab66d3294b3e7fc4322af19..e16cae92da7609585af2af62cbc35fe1aa41bb0c 100644

--- a/frog/gen.dart

+++ b/frog/gen.dart

@@ -2109,12 +2109,7 @@ class MethodGenerator implements TreeVisitor {

constructorName = '';

}

- if (method.isStatic

- && ((method.typeParameters === null && type.hasTypeParams)

- || type is ParameterType)) {

- world.error('using type parameter in static context', node.span);

- return _makeMissingValue(constructorName);

- } else if (type is ParameterType) {

+ if (type is ParameterType) {

world.error('cannot instantiate a type parameter', node.span);

return _makeMissingValue(constructorName);

}

« no previous file with comments | « no previous file | frog/member.dart » ('j') | no next file with comments »