Issue 8826013: Respect command line flags for interstitial pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8826013: Respect command line flags for interstitial pages. (Closed)

Created:
9 years ago by no sievers

Modified:
9 years ago

Reviewers:
jcivelli, Vangelis Kokkevis, brettw

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Respect command line flags for interstitial pages. InterstitialPage implements RenderViewHostDelegate but does not override GetWebkitPrefs() which in the base class only returns default settings. For example, this does not allow compositing for interstitial pages ever. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113352

Patch Set 1 #

Patch Set 2 : remove logic to explicitly disallow compositing #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	content/browser/tab_contents/interstitial_page.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	content/browser/tab_contents/interstitial_page.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

no sievers

Vangelis: Would you prefer a separate settings to allow compositing for these pages rather than ...

9 years ago (2011-12-07 00:30:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/8826013/3001

9 years ago (2011-12-07 04:03:13 UTC) #4

Change committed as 113352

Expand Messages | Collapse Messages