Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2895)

Unified Diff: ppapi/proxy/ppb_var_deprecated_proxy.cc

Issue 8826011: Remove PP_Module from parameters for PPB_Var.VarFromUtf8. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/ppb_font_proxy.cc ('k') | ppapi/proxy/ppb_var_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/ppb_var_deprecated_proxy.cc
diff --git a/ppapi/proxy/ppb_var_deprecated_proxy.cc b/ppapi/proxy/ppb_var_deprecated_proxy.cc
index 2594d268d72d003255d5f2d878660f35eeb26f6c..f81f3194f420ac61117195f819336e4780e43e65 100644
--- a/ppapi/proxy/ppb_var_deprecated_proxy.cc
+++ b/ppapi/proxy/ppb_var_deprecated_proxy.cc
@@ -12,6 +12,7 @@
#include "base/task.h"
#include "ppapi/c/dev/ppb_var_deprecated.h"
#include "ppapi/c/pp_var.h"
+#include "ppapi/c/ppb_var.h"
#include "ppapi/c/ppb_core.h"
#include "ppapi/proxy/host_dispatcher.h"
#include "ppapi/proxy/plugin_dispatcher.h"
@@ -21,6 +22,7 @@
#include "ppapi/proxy/ppapi_messages.h"
#include "ppapi/proxy/ppp_class_proxy.h"
#include "ppapi/proxy/serialized_var.h"
+#include "ppapi/shared_impl/ppb_var_impl.h"
#include "ppapi/shared_impl/var.h"
namespace ppapi {
@@ -52,7 +54,7 @@ PluginDispatcher* CheckExceptionAndGetDispatcher(const PP_Var& object,
// The object is invalid. This means we can't figure out which dispatcher
// to use, which is OK because the call will fail anyway. Set the exception.
if (exception) {
- *exception = StringVar::StringToPPVar(0,
+ *exception = StringVar::StringToPPVar(
std::string("Attempting to use an invalid object"));
}
return NULL;
@@ -60,28 +62,6 @@ PluginDispatcher* CheckExceptionAndGetDispatcher(const PP_Var& object,
// PPB_Var_Deprecated plugin ---------------------------------------------------
-void AddRefVar(PP_Var var) {
- PpapiGlobals::Get()->GetVarTracker()->AddRefVar(var);
-}
-
-void ReleaseVar(PP_Var var) {
- PpapiGlobals::Get()->GetVarTracker()->ReleaseVar(var);
-}
-
-PP_Var VarFromUtf8(PP_Module module, const char* data, uint32_t len) {
- return StringVar::StringToPPVar(module, data, len);
-}
-
-const char* VarToUtf8(PP_Var var, uint32_t* len) {
- StringVar* str = StringVar::FromPPVar(var);
- if (str) {
- *len = static_cast<uint32_t>(str->value().size());
- return str->value().c_str();
- }
- *len = 0;
- return NULL;
-}
-
bool HasProperty(PP_Var var,
PP_Var name,
PP_Var* exception) {
@@ -274,23 +254,6 @@ PP_Var CreateObject(PP_Instance instance,
return result.Return(dispatcher);
}
-const PPB_Var_Deprecated var_deprecated_interface = {
- &AddRefVar,
- &ReleaseVar,
- &VarFromUtf8,
- &VarToUtf8,
- &HasProperty,
- &HasMethod,
- &GetProperty,
- &EnumerateProperties,
- &SetProperty,
- &RemoveProperty,
- &Call,
- &Construct,
- &IsInstanceOf,
- &CreateObject
-};
-
InterfaceProxy* CreateVarDeprecatedProxy(Dispatcher* dispatcher) {
return new PPB_Var_Deprecated_Proxy(dispatcher );
}
@@ -313,6 +276,23 @@ PPB_Var_Deprecated_Proxy::~PPB_Var_Deprecated_Proxy() {
// static
const InterfaceProxy::Info* PPB_Var_Deprecated_Proxy::GetInfo() {
+ static const PPB_Var_Deprecated var_deprecated_interface = {
+ ppapi::PPB_Var_Impl::GetVarInterface1_0()->AddRef,
+ ppapi::PPB_Var_Impl::GetVarInterface1_0()->Release,
+ ppapi::PPB_Var_Impl::GetVarInterface1_0()->VarFromUtf8,
+ ppapi::PPB_Var_Impl::GetVarInterface1_0()->VarToUtf8,
+ &HasProperty,
+ &HasMethod,
+ &GetProperty,
+ &EnumerateProperties,
+ &SetProperty,
+ &RemoveProperty,
+ &Call,
+ &Construct,
+ &IsInstanceOf,
+ &CreateObject
+ };
+
static const Info info = {
&var_deprecated_interface,
PPB_VAR_DEPRECATED_INTERFACE,
« no previous file with comments | « ppapi/proxy/ppb_font_proxy.cc ('k') | ppapi/proxy/ppb_var_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698