Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: ppapi/native_client/tests/ppapi_test_lib/test_interface.cc

Issue 8826011: Remove PP_Module from parameters for PPB_Var.VarFromUtf8. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix windows build and some nacl tests. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/tests/ppapi_test_lib/test_interface.cc
diff --git a/ppapi/native_client/tests/ppapi_test_lib/test_interface.cc b/ppapi/native_client/tests/ppapi_test_lib/test_interface.cc
index 55b52ff61ff43bc7bfd9a78789315542dac52f96..c574bea279038565d65951c07ea973a6e1e83a73 100644
--- a/ppapi/native_client/tests/ppapi_test_lib/test_interface.cc
+++ b/ppapi/native_client/tests/ppapi_test_lib/test_interface.cc
@@ -30,15 +30,14 @@ void PostTestMessage(nacl::string test_name, nacl::string message) {
nacl::string test_message = test_name;
test_message += ":";
test_message += message;
- PP_Var post_var = PPBVar()->VarFromUtf8(pp_instance(),
bbudge 2011/12/07 15:53:28 This was passing the instance instead of the modul
dmichael (off chromium) 2011/12/07 18:07:38 Yep! Fortunately(?) we didn't really use the modul
- test_message.c_str(),
+ PP_Var post_var = PPBVar()->VarFromUtf8(test_message.c_str(),
test_message.size());
PPBMessaging()->PostMessage(pp_instance(), post_var);
PPBVar()->Release(post_var);
}
PP_Var PP_MakeString(const char* s) {
- return PPBVar()->VarFromUtf8(pp_module(), s, strlen(s));
+ return PPBVar()->VarFromUtf8(s, strlen(s));
}
nacl::string StringifyVar(const PP_Var& var) {
@@ -120,8 +119,7 @@ struct CallbackInfo {
};
void ReportCallbackInvocationToJS(const char* callback_name) {
- PP_Var callback_var = PPBVar()->VarFromUtf8(pp_module(),
- callback_name,
+ PP_Var callback_var = PPBVar()->VarFromUtf8(callback_name,
strlen(callback_name));
// Report using postmessage for async tests.
PPBMessaging()->PostMessage(pp_instance(), callback_var);

Powered by Google App Engine
This is Rietveld 408576698