runtime/include/dart_dapi.h - Issue 8826007: First bits of external debugger API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/include/dart_dapi.h

Issue 8826007: First bits of external debugger API (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

Property Changes:

Added: svn:executable
+ *

OLD	NEW
(Empty)
	1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 #ifndef INCLUDE_DART_DAPI_H_

	6 #define INCLUDE_DART_DAPI_H_

	7

	8
	siva 2011/12/07 05:44:48 extra blank line? extra blank line? hausner 2011/12/07 22:14:26 Done. Show quoted text On 2011/12/07 05:44:48, asiva wrote: > extra blank line? Done.
	9 #include "include/dart_api.h"

	10

	11 typedef struct _Dart_Breakpoint* Dart_Breakpoint;

	12

	13

	14 DART_EXPORT void Dart_InitDebugger();
	siva 2011/12/07 05:44:48 Is Dart_InitDebugger guaranteed not to fail? Is Dart_InitDebugger guaranteed not to fail? hausner 2011/12/07 22:14:26 At this point, it always succeeds. But it makes se Show quoted text On 2011/12/07 05:44:48, asiva wrote: > Is Dart_InitDebugger guaranteed not to fail? At this point, it always succeeds. But it makes sense to add a return value. Done.
	15

	16 DART_EXPORT Dart_Handle Dart_SetBreakpointAtEntry(

	17 Dart_Handle library,

	18 Dart_Handle class_name,

	19 Dart_Handle function_name,

	20 Dart_Breakpoint* breakpoint);
	siva 2011/12/07 05:44:48 Todd has been adding some documentation on top of Todd has been adding some documentation on top of each of these API functions, see dart_api.h. It might be useful to continue that in this file too. hausner 2011/12/07 22:14:26 Added proper function comment. Show quoted text On 2011/12/07 05:44:48, asiva wrote: > Todd has been adding some documentation on top of each of these API functions, > see dart_api.h. > It might be useful to continue that in this file too. Added proper function comment.
	21

	22 #endif // INCLUDE_DART_DAPI_H_

OLD	NEW

« runtime/bin/main.cc ('K') | « runtime/dart-runtime.gyp ('k') | runtime/vm/code_generator_ia32.cc » ('j') | runtime/vm/dart_dapi_impl.cc » ('J')