frog bug 642: type variables can't be used in allocations.

frog/gen.dart

Index: frog/gen.dart
diff --git a/frog/gen.dart b/frog/gen.dart
index efb7f07164848ba44297b43c6f5dfc98a1b5ff4b..ceb3b403d573fa0f8ab66d3294b3e7fc4322af19 100644
--- a/frog/gen.dart
+++ b/frog/gen.dart
@@ -2109,6 +2109,16 @@ class MethodGenerator implements TreeVisitor {
       constructorName = '';
     }
 
+    if (method.isStatic
+        && ((method.typeParameters === null && type.hasTypeParams)

[Jennifer Messerly, 2011/12/06 22:14:55]

I don't understand the (method.typeParameters === null && type.hasTypeParams)
part

Also, could this just be one warning:

if (type is ParameterType) {
  world.error('cannot instantiate a type parameter', node.span);
   return _makeMissingValue(constructorName);
}

IMHO, there's not a lot of value in checking 2 things here.

However, we probably still need the other error, but it needs to happen
somewhere else (like resolveType?) because you can refer to a type in other ways
besides a "new", for example:

class SomeType<T> {
  static foo() {
    T t = bar(); // or "bar is T"
    return t; 
  }
}

The boolean parameter to resolveType is called "isRequired" but it really
*means* something along the lines of "isStaticContext"

+          || type is ParameterType)) {
+      world.error('using type parameter in static context', node.span);
+      return _makeMissingValue(constructorName);
+    } else if (type is ParameterType) {
+      world.error('cannot instantiate a type parameter', node.span);
+      return _makeMissingValue(constructorName);
+    }
+
     var m = type.getConstructor(constructorName);
     if (m == null) {
       var name = type.jsname;