Create a LegacyExtensionBrowserTest class that lets us test extensions with

Mark a handful of tests as using legacy manifest versions.  We could convert
these tests to using manifest_version 2, but it looks like more effort than
it's worth.

BUG=62897
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113466

[Aaron Boodman, 2011-12-07 01:21:27]

Not too crazy about subclassing for this.

Do you even need anything in ExtensionBrowserTest? Can't you just AppendFlag()
at the beginning of the tests that need this behavior?

[abarth-chromium, 2011-12-07 03:08:44]

I've updated the patch to not use subclasses for the generic
ExtensionBrowserTests.  I did override the method in a couple other tests that
already had empty subclasses.

Let me know what you think.  Thanks.

[Aaron Boodman, 2011-12-07 20:32:20]

lgtm

http://codereview.chromium.org/8825015/diff/3001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_icon_source_apitest.cc (right):

http://codereview.chromium.org/8825015/diff/3001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_icon_source_apitest.cc:19: void
SetUpCommandLine(CommandLine* command_line) OVERRIDE {
Chrome style is to mark overridding methods virtual.

[abarth-chromium, 2011-12-07 20:52:40]

Thanks.

[commit-bot: I haz the power, 2011-12-07 20:52:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/8825015/7002