src/mksnapshot.cc - Issue 8825003: Fix GCC 4.7 warnings, which are related to char being signed in GCC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mksnapshot.cc

Issue 8825003: Fix GCC 4.7 warnings, which are related to char being signed in GCC (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Fix GCC 4.7 warnings, which are related to char being signed in GCC Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mksnapshot.cc

===================================================================

--- src/mksnapshot.cc (revision 10237)

+++ src/mksnapshot.cc (working copy)

@@ -109,7 +109,7 @@

if (j != 0) {

fprintf(fp, ",");

}

- fprintf(fp, "%d", at(j));

+ fprintf(fp, "%u", static_cast<unsigned char>(at(j)));

}

char at(int i) { return data_[i]; }

« no previous file with comments | « AUTHORS ('k') | test/cctest/test-regexp.cc » ('j') | no next file with comments »