Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3658)

Unified Diff: base/path_service.h

Issue 8825: Begin the first small step towards using FilePath everywhere: (Closed)
Patch Set: works on windows Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/icu_util.cc ('k') | base/path_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/path_service.h
diff --git a/base/path_service.h b/base/path_service.h
index e449efa9cad1eba65166d10372e1f8526a4745f6..c00e31c65691cd476cd2e053f9dbf7831bb9fbd5 100644
--- a/base/path_service.h
+++ b/base/path_service.h
@@ -19,6 +19,8 @@
#include "base/base_paths.h"
+class FilePath;
+
// The path service is a global table mapping keys to file system paths. It is
// OK to use this service from multiple threads.
//
@@ -31,6 +33,9 @@ class PathService {
//
// Returns true if the directory or file was successfully retrieved. On
// failure, 'path' will not be changed.
+ static bool Get(int key, FilePath* path);
+ // This version, producing a wstring, is deprecated and only kept around
+ // until we can fix all callers.
static bool Get(int key, std::wstring* path);
// Overrides the path to a special directory or file. This cannot be used to
@@ -66,8 +71,8 @@ class PathService {
int key_start,
int key_end);
private:
- static bool GetFromCache(int key, std::wstring* path);
- static void AddToCache(int key, const std::wstring& path);
+ static bool GetFromCache(int key, FilePath* path);
+ static void AddToCache(int key, const FilePath& path);
};
« no previous file with comments | « base/icu_util.cc ('k') | base/path_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698