Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 8824017: Aura Shell singleton needs to be destroyed prior to the Aura Desktop (Closed)

Created:
9 years ago by dhollowa
Modified:
9 years ago
Reviewers:
xiyuan, sky
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Aura Shell singleton needs to be destroyed prior to the Aura Desktop Adds code to explicitly destroy the Aura Shell class prior to the destruction of Aura Desktop. The reason for this is that the Shell leaks the DesktopFilter event listeners otherwise and DCHECKs fire. Note, this currently only affects the Mac port because other platforms exit() from the run loop and don't do explicit tear-down. BUG=none TEST=Manually run aura_shell_exe on Mac. R=sky@chromium.org, xiyuan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113415

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/aura_shell/examples/aura_shell_main.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dhollowa
9 years ago (2011-12-07 00:28:52 UTC) #1
xiyuan
This looks good to me. But let's listen to what sky says about it. :)
9 years ago (2011-12-07 00:32:32 UTC) #2
sky
9 years ago (2011-12-07 04:46:46 UTC) #3
This matches what we do in chrome_browser_main_extra_parts_aura.

LGTM

Powered by Google App Engine
This is Rietveld 408576698