Issue 8824009: Attempt fixes at chrome frame tests redness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8824009: Attempt fixes at chrome frame tests redness. (Closed)

Created:
9 years ago by David Tseng

Modified:
9 years ago

Reviewers:
Raghu Simha, dtseng

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

More Reviews

Description

Attempt fixes at chrome frame tests redness. TBR=dtseng BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113267

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/renderer/renderer_accessibility.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Raghu Simha

9 years ago (2011-12-06 22:25:04 UTC) #1

Drive by comment below. Feel free to land this.

http://codereview.chromium.org/8824009/diff/1/content/renderer/renderer_acces...
File content/renderer/renderer_accessibility.cc (right):

http://codereview.chromium.org/8824009/diff/1/content/renderer/renderer_acces...
content/renderer/renderer_accessibility.cc:161: // Load complete should be our
first notification sent. Send it manually
nit: Should this comment be changed to indicate that you're sending the "Layout
complete" notification?

Expand Messages | Collapse Messages