Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: ui/views/widget/native_widget_aura.cc

Issue 8824007: Revert 113224 - IME (input method editor) support for Aura, part 3 of 3: Use ui::InputMethod in u... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/keycodes/keyboard_code_conversion_x.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/native_widget_aura.cc
===================================================================
--- ui/views/widget/native_widget_aura.cc (revision 113258)
+++ ui/views/widget/native_widget_aura.cc (working copy)
@@ -32,7 +32,7 @@
#endif
#if defined(HAVE_IBUS)
-#include "ui/views/ime/input_method_bridge.h"
+#include "ui/views/ime/input_method_ibus.h"
#else
#include "ui/views/ime/mock_input_method.h"
#endif
@@ -278,10 +278,8 @@
InputMethod* NativeWidgetAura::CreateInputMethod() {
#if defined(HAVE_IBUS)
- ui::InputMethod* host = aura::Desktop::GetInstance()->GetInputMethod();
- InputMethod* input_method = new InputMethodBridge(this, host);
+ InputMethod* input_method = new InputMethodIBus(this);
#else
- // Use the mock IME for unit tests.
InputMethod* input_method = new MockInputMethod(this);
#endif
input_method->Init(GetWidget());
@@ -573,14 +571,15 @@
}
bool NativeWidgetAura::OnKeyEvent(aura::KeyEvent* event) {
- // TODO(yusukes): Need an ui::InputMethod to properly handle character events.
- // Right now, we just skip these.
+ // TODO(beng): Need an InputMethodAura to properly handle character events.
+ // Right now, we just skip these.
if (event->is_char())
return false;
DCHECK(window_->IsVisible());
InputMethod* input_method = GetWidget()->GetInputMethod();
DCHECK(input_method);
+ // TODO(oshima): DispatchKeyEvent should return bool?
KeyEvent views_event(event);
input_method->DispatchKeyEvent(views_event);
return true;
« no previous file with comments | « ui/base/keycodes/keyboard_code_conversion_x.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698