Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: net/socket/deterministic_socket_data_unittest.cc

Issue 8824006: Migrate net/socket/socket.h, net/socket/stream_socket.h to base::Bind(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/client_socket_pool_base_unittest.cc ('k') | net/socket/socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/deterministic_socket_data_unittest.cc
diff --git a/net/socket/deterministic_socket_data_unittest.cc b/net/socket/deterministic_socket_data_unittest.cc
index cb6ca32b477cf779678e00bf8935c6950da1a446..8740c8da5b412e0493e1e33e02ff53d4624e905f 100644
--- a/net/socket/deterministic_socket_data_unittest.cc
+++ b/net/socket/deterministic_socket_data_unittest.cc
@@ -41,8 +41,8 @@ class DeterministicSocketDataTest : public PlatformTest {
void AssertAsyncWriteEquals(const char* data, int len);
void AssertWriteReturns(const char* data, int len, int rv);
- TestOldCompletionCallback read_callback_;
- TestOldCompletionCallback write_callback_;
+ TestCompletionCallback read_callback_;
+ TestCompletionCallback write_callback_;
StreamSocket* sock_;
scoped_refptr<DeterministicSocketData> data_;
@@ -61,9 +61,7 @@ class DeterministicSocketDataTest : public PlatformTest {
};
DeterministicSocketDataTest::DeterministicSocketDataTest()
- : read_callback_(),
- write_callback_(),
- sock_(NULL),
+ : sock_(NULL),
data_(NULL),
read_buf_(NULL),
connect_data_(false, OK),
@@ -125,7 +123,7 @@ void DeterministicSocketDataTest::AssertAsyncReadEquals(const char* data,
void DeterministicSocketDataTest::AssertReadReturns(const char* data,
int len, int rv) {
read_buf_ = new IOBuffer(len);
- ASSERT_EQ(rv, sock_->Read(read_buf_, len, &read_callback_));
+ ASSERT_EQ(rv, sock_->Read(read_buf_, len, read_callback_.callback()));
}
void DeterministicSocketDataTest::AssertReadBufferEquals(const char* data,
@@ -139,7 +137,7 @@ void DeterministicSocketDataTest::AssertSyncWriteEquals(const char* data,
memcpy(buf->data(), data, len);
// Issue the write, which will complete immediately
- ASSERT_EQ(len, sock_->Write(buf, len, &write_callback_));
+ ASSERT_EQ(len, sock_->Write(buf, len, write_callback_.callback()));
}
void DeterministicSocketDataTest::AssertAsyncWriteEquals(const char* data,
@@ -160,7 +158,7 @@ void DeterministicSocketDataTest::AssertWriteReturns(const char* data,
memcpy(buf->data(), data, len);
// Issue the read, which will complete asynchronously
- ASSERT_EQ(rv, sock_->Write(buf, len, &write_callback_));
+ ASSERT_EQ(rv, sock_->Write(buf, len, write_callback_.callback()));
}
// ----------- Read
« no previous file with comments | « net/socket/client_socket_pool_base_unittest.cc ('k') | net/socket/socket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698