Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: net/socket/client_socket_pool_base_unittest.cc

Issue 8824006: Migrate net/socket/socket.h, net/socket/stream_socket.h to base::Bind(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_parser.cc ('k') | net/socket/deterministic_socket_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_pool_base_unittest.cc
diff --git a/net/socket/client_socket_pool_base_unittest.cc b/net/socket/client_socket_pool_base_unittest.cc
index 779b8dee0f18aa9adba3166dd2f693921f2db051..1aac330e94a8c1ec2cd9104de57d5e6ce773122c 100644
--- a/net/socket/client_socket_pool_base_unittest.cc
+++ b/net/socket/client_socket_pool_base_unittest.cc
@@ -63,18 +63,15 @@ class MockClientSocket : public StreamSocket {
// Socket implementation.
virtual int Read(
- IOBuffer* /* buf */, int len, OldCompletionCallback* /* callback */) {
- num_bytes_read_ += len;
- return len;
- }
- virtual int Read(
- IOBuffer* /* buf */, int len, const CompletionCallback& /* callback */) {
+ IOBuffer* /* buf */, int len,
+ const CompletionCallback& /* callback */) OVERRIDE {
num_bytes_read_ += len;
return len;
}
virtual int Write(
- IOBuffer* /* buf */, int len, OldCompletionCallback* /* callback */) {
+ IOBuffer* /* buf */, int len,
+ const CompletionCallback& /* callback */) OVERRIDE {
was_used_to_convey_data_ = true;
return len;
}
@@ -82,11 +79,7 @@ class MockClientSocket : public StreamSocket {
virtual bool SetSendBufferSize(int32 size) { return true; }
// StreamSocket implementation.
- virtual int Connect(OldCompletionCallback* callback) {
- connected_ = true;
- return OK;
- }
- virtual int Connect(const net::CompletionCallback& callback) {
+ virtual int Connect(const CompletionCallback& callback) OVERRIDE {
connected_ = true;
return OK;
}
@@ -328,7 +321,7 @@ class TestConnectJob : public ConnectJob {
int DoConnect(bool succeed, bool was_async, bool recoverable) {
int result = OK;
if (succeed) {
- socket()->Connect(NULL);
+ socket()->Connect(CompletionCallback());
} else if (recoverable) {
result = ERR_PROXY_AUTH_REQUESTED;
} else {
@@ -384,6 +377,7 @@ class TestConnectJobFactory
}
// ConnectJobFactory implementation.
+
virtual ConnectJob* NewConnectJob(
const std::string& group_name,
const TestClientSocketPoolBase::Request& request,
@@ -677,7 +671,7 @@ TEST_F(ClientSocketPoolBaseTest, AssignIdleSocketToGroup_WarmestSocket) {
MockClientSocket* sock = static_cast<MockClientSocket*>(s);
CHECK(sock);
sockets_[i] = sock;
- sock->Read(NULL, 1024 - i, NULL);
+ sock->Read(NULL, 1024 - i, CompletionCallback());
}
ReleaseAllConnections(ClientSocketPoolTest::KEEP_ALIVE);
@@ -713,7 +707,7 @@ TEST_F(ClientSocketPoolBaseTest, AssignIdleSocketToGroup_LastAccessedSocket) {
MockClientSocket* sock = static_cast<MockClientSocket*>(s);
CHECK(sock);
sockets_[i] = sock;
- sock->Read(NULL, 1024 - i, NULL);
+ sock->Read(NULL, 1024 - i, CompletionCallback());
}
ReleaseAllConnections(ClientSocketPoolTest::KEEP_ALIVE);
@@ -2037,7 +2031,7 @@ TEST_F(ClientSocketPoolBaseTest, DisableCleanupTimer) {
handle.Reset();
EXPECT_EQ(OK, callback2.WaitForResult());
// Use the socket.
- EXPECT_EQ(1, handle2.socket()->Write(NULL, 1, NULL));
+ EXPECT_EQ(1, handle2.socket()->Write(NULL, 1, CompletionCallback()));
handle2.Reset();
// The idle socket timeout value was set to 10 milliseconds. Wait 100
@@ -2111,7 +2105,7 @@ TEST_F(ClientSocketPoolBaseTest, CleanupTimedOutIdleSockets) {
handle.Reset();
EXPECT_EQ(OK, callback2.WaitForResult());
// Use the socket.
- EXPECT_EQ(1, handle2.socket()->Write(NULL, 1, NULL));
+ EXPECT_EQ(1, handle2.socket()->Write(NULL, 1, CompletionCallback()));
handle2.Reset();
// We post all of our delayed tasks with a 2ms delay. I.e. they don't
@@ -2872,8 +2866,8 @@ TEST_F(ClientSocketPoolBaseTest, PreferUsedSocketToUnusedSocket) {
EXPECT_EQ(OK, callback3.WaitForResult());
// Use the socket.
- EXPECT_EQ(1, handle1.socket()->Write(NULL, 1, NULL));
- EXPECT_EQ(1, handle3.socket()->Write(NULL, 1, NULL));
+ EXPECT_EQ(1, handle1.socket()->Write(NULL, 1, CompletionCallback()));
+ EXPECT_EQ(1, handle3.socket()->Write(NULL, 1, CompletionCallback()));
handle1.Reset();
handle2.Reset();
« no previous file with comments | « net/http/http_stream_parser.cc ('k') | net/socket/deterministic_socket_data_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698