| Index: net/socket/socks5_client_socket_unittest.cc
|
| diff --git a/net/socket/socks5_client_socket_unittest.cc b/net/socket/socks5_client_socket_unittest.cc
|
| index 85b07b8a206584389c391a9bb04a72caece6ca1f..72f015a2c312c55b88fa8671a093eb6a0c7809d3 100644
|
| --- a/net/socket/socks5_client_socket_unittest.cc
|
| +++ b/net/socket/socks5_client_socket_unittest.cc
|
| @@ -47,7 +47,7 @@ class SOCKS5ClientSocketTest : public PlatformTest {
|
| scoped_ptr<SOCKS5ClientSocket> user_sock_;
|
| AddressList address_list_;
|
| StreamSocket* tcp_sock_;
|
| - TestOldCompletionCallback callback_;
|
| + TestCompletionCallback callback_;
|
| scoped_ptr<MockHostResolver> host_resolver_;
|
| scoped_ptr<SocketDataProvider> data_;
|
|
|
| @@ -83,12 +83,12 @@ SOCKS5ClientSocket* SOCKS5ClientSocketTest::BuildMockSocket(
|
| const std::string& hostname,
|
| int port,
|
| NetLog* net_log) {
|
| - TestOldCompletionCallback callback;
|
| + TestCompletionCallback callback;
|
| data_.reset(new StaticSocketDataProvider(reads, reads_count,
|
| writes, writes_count));
|
| tcp_sock_ = new MockTCPClientSocket(address_list_, net_log, data_.get());
|
|
|
| - int rv = tcp_sock_->Connect(&callback);
|
| + int rv = tcp_sock_->Connect(callback.callback());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
| rv = callback.WaitForResult();
|
| EXPECT_EQ(OK, rv);
|
| @@ -131,7 +131,7 @@ TEST_F(SOCKS5ClientSocketTest, CompleteHandshake) {
|
| EXPECT_TRUE(tcp_sock_->IsConnected());
|
| EXPECT_FALSE(user_sock_->IsConnected());
|
|
|
| - int rv = user_sock_->Connect(&callback_);
|
| + int rv = user_sock_->Connect(callback_.callback());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
| EXPECT_FALSE(user_sock_->IsConnected());
|
|
|
| @@ -151,13 +151,13 @@ TEST_F(SOCKS5ClientSocketTest, CompleteHandshake) {
|
|
|
| scoped_refptr<IOBuffer> buffer(new IOBuffer(payload_write.size()));
|
| memcpy(buffer->data(), payload_write.data(), payload_write.size());
|
| - rv = user_sock_->Write(buffer, payload_write.size(), &callback_);
|
| + rv = user_sock_->Write(buffer, payload_write.size(), callback_.callback());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
| rv = callback_.WaitForResult();
|
| EXPECT_EQ(static_cast<int>(payload_write.size()), rv);
|
|
|
| buffer = new IOBuffer(payload_read.size());
|
| - rv = user_sock_->Read(buffer, payload_read.size(), &callback_);
|
| + rv = user_sock_->Read(buffer, payload_read.size(), callback_.callback());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
| rv = callback_.WaitForResult();
|
| EXPECT_EQ(static_cast<int>(payload_read.size()), rv);
|
| @@ -197,7 +197,7 @@ TEST_F(SOCKS5ClientSocketTest, ConnectAndDisconnectTwice) {
|
| data_writes, arraysize(data_writes),
|
| hostname, 80, NULL));
|
|
|
| - int rv = user_sock_->Connect(&callback_);
|
| + int rv = user_sock_->Connect(callback_.callback());
|
| EXPECT_EQ(OK, rv);
|
| EXPECT_TRUE(user_sock_->IsConnected());
|
|
|
| @@ -221,8 +221,8 @@ TEST_F(SOCKS5ClientSocketTest, LargeHostNameFails) {
|
|
|
| // Try to connect -- should fail (without having read/written anything to
|
| // the transport socket first) because the hostname is too long.
|
| - TestOldCompletionCallback callback;
|
| - int rv = user_sock_->Connect(&callback);
|
| + TestCompletionCallback callback;
|
| + int rv = user_sock_->Connect(callback.callback());
|
| EXPECT_EQ(ERR_SOCKS_CONNECTION_FAILED, rv);
|
| }
|
|
|
| @@ -254,7 +254,7 @@ TEST_F(SOCKS5ClientSocketTest, PartialReadWrites) {
|
| user_sock_.reset(BuildMockSocket(data_reads, arraysize(data_reads),
|
| data_writes, arraysize(data_writes),
|
| hostname, 80, &net_log_));
|
| - int rv = user_sock_->Connect(&callback_);
|
| + int rv = user_sock_->Connect(callback_.callback());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
|
|
| net::CapturingNetLog::EntryList net_log_entries;
|
| @@ -285,7 +285,7 @@ TEST_F(SOCKS5ClientSocketTest, PartialReadWrites) {
|
| user_sock_.reset(BuildMockSocket(data_reads, arraysize(data_reads),
|
| data_writes, arraysize(data_writes),
|
| hostname, 80, &net_log_));
|
| - int rv = user_sock_->Connect(&callback_);
|
| + int rv = user_sock_->Connect(callback_.callback());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
|
|
| net::CapturingNetLog::EntryList net_log_entries;
|
| @@ -315,7 +315,7 @@ TEST_F(SOCKS5ClientSocketTest, PartialReadWrites) {
|
| user_sock_.reset(BuildMockSocket(data_reads, arraysize(data_reads),
|
| data_writes, arraysize(data_writes),
|
| hostname, 80, &net_log_));
|
| - int rv = user_sock_->Connect(&callback_);
|
| + int rv = user_sock_->Connect(callback_.callback());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
| net::CapturingNetLog::EntryList net_log_entries;
|
| net_log_.GetEntries(&net_log_entries);
|
| @@ -346,7 +346,7 @@ TEST_F(SOCKS5ClientSocketTest, PartialReadWrites) {
|
| user_sock_.reset(BuildMockSocket(data_reads, arraysize(data_reads),
|
| data_writes, arraysize(data_writes),
|
| hostname, 80, &net_log_));
|
| - int rv = user_sock_->Connect(&callback_);
|
| + int rv = user_sock_->Connect(callback_.callback());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
| net::CapturingNetLog::EntryList net_log_entries;
|
| net_log_.GetEntries(&net_log_entries);
|
|
|