Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 8824006: Migrate net/socket/socket.h, net/socket/stream_socket.h to base::Bind(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: small win fix Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index c3a9d11a4b085b4d6cab68c18335033b467f1e53..ed7c9d29223b12d26899b8db4b410b28b3f8a5b2 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -7618,15 +7618,16 @@ TEST_F(HttpNetworkTransactionTest,
spdy_writes, arraysize(spdy_writes)));
session_deps.socket_factory.AddSocketDataProvider(spdy_data);
- TestOldCompletionCallback callback;
+ TestOldCompletionCallback callback_old;
+ TestCompletionCallback callback;
scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps));
scoped_ptr<HttpNetworkTransaction> trans(new HttpNetworkTransaction(session));
- int rv = trans->Start(&request, &callback, BoundNetLog());
+ int rv = trans->Start(&request, &callback_old, BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
- EXPECT_EQ(OK, callback.WaitForResult());
+ EXPECT_EQ(OK, callback_old.WaitForResult());
const HttpResponseInfo* response = trans->GetResponseInfo();
ASSERT_TRUE(response != NULL);
@@ -7650,10 +7651,10 @@ TEST_F(HttpNetworkTransactionTest,
connection->Init(host_port_pair.ToString(),
transport_params,
LOWEST,
- &callback,
+ &callback_old,
session->GetTransportSocketPool(),
BoundNetLog()));
- EXPECT_EQ(OK, callback.WaitForResult());
+ EXPECT_EQ(OK, callback_old.WaitForResult());
SSLConfig ssl_config;
session->ssl_config_service()->GetSSLConfig(&ssl_config);
@@ -7663,7 +7664,8 @@ TEST_F(HttpNetworkTransactionTest,
ssl_connection->set_socket(session_deps.socket_factory.CreateSSLClientSocket(
connection.release(), HostPortPair("" , 443), ssl_config,
NULL /* ssl_host_info */, context));
- EXPECT_EQ(ERR_IO_PENDING, ssl_connection->socket()->Connect(&callback));
+ EXPECT_EQ(ERR_IO_PENDING,
+ ssl_connection->socket()->Connect(callback.callback()));
EXPECT_EQ(OK, callback.WaitForResult());
EXPECT_EQ(OK, spdy_session->InitializeWithSocket(ssl_connection.release(),
@@ -7671,9 +7673,9 @@ TEST_F(HttpNetworkTransactionTest,
trans.reset(new HttpNetworkTransaction(session));
- rv = trans->Start(&request, &callback, BoundNetLog());
+ rv = trans->Start(&request, &callback_old, BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
- EXPECT_EQ(OK, callback.WaitForResult());
+ EXPECT_EQ(OK, callback_old.WaitForResult());
response = trans->GetResponseInfo();
ASSERT_TRUE(response != NULL);

Powered by Google App Engine
This is Rietveld 408576698