SPDY PING - log the type of PING if it is received

SPDY PING - log the type of PING if it is received
or sent ping (like below):

t=1323200233634 [st=196851]     SPDY_SESSION_PING
                                --> type = "sent"
                                --> unique_id = 3
t=1323200233638 [st=196855]     SPDY_SESSION_PING
                                --> type = "received"
                                --> unique_id = 3
BUG=106499
R=willchan
TEST=spdy unit tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113295

[ramant (doing other things), 2011-12-06 21:54:48]

Hi willchan,
  Added logging of ping type. Would appreciate your comments.

thanks,
raman

[willchan no longer on Chromium, 2011-12-06 21:58:16]

LGTM, thanks!

On Tue, Dec 6, 2011 at 1:54 PM, <rtenneti@chromium.org> wrote:

> Reviewers: willchan,
>
> Message:
> Hi willchan,
>  Added logging of ping type. Would appreciate your comments.
>
> thanks,
> raman
>
> Description:
> SPDY PING - log the type of PING if it is received
> or sent ping (like below):
>
> t=1323200233634 [st=196851]     SPDY_SESSION_PING
>                                --> type = "sent"
>                                --> unique_id = 3
> t=1323200233638 [st=196855]     SPDY_SESSION_PING
>                                --> type = "received"
>                                --> unique_id = 3
> BUG=106499
> R=willchan
> TEST=spdy unit tests
>
> Please review this at
http://codereview.chromium.**org/8824005/<http://codereview.chromium.org/8824...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     net/base/net_log_event_type_**list.h
>  M     net/spdy/spdy_session.cc
>
>
> Index: net/base/net_log_event_type_**list.h
> ==============================**==============================**=======
> --- net/base/net_log_event_type_**list.h  (revision 113052)
> +++ net/base/net_log_event_type_**list.h  (working copy)
> @@ -952,6 +952,7 @@
>  // The following parameters are attached:
>  //   {
>  //     "unique_id": <The unique id of the PING message>,
> +//     "type": <The PING type ("sent", "received")>,
>  //   }
>  EVENT_TYPE(SPDY_SESSION_PING)
>
> Index: net/spdy/spdy_session.cc
> ==============================**==============================**=======
> --- net/spdy/spdy_session.cc    (revision 112817)
> +++ net/spdy/spdy_session.cc    (working copy)
> @@ -175,17 +175,21 @@
>
>  class NetLogSpdyPingParameter : public NetLog::EventParameters {
>  public:
> -  explicit NetLogSpdyPingParameter(uint32 unique_id) :
> unique_id_(unique_id) {}
> +  explicit NetLogSpdyPingParameter(uint32 unique_id, const std::string&
> type)
> +    : unique_id_(unique_id),
> +      type_(type) {}
>
>   virtual Value* ToValue() const {
>     DictionaryValue* dict = new DictionaryValue();
>     dict->SetInteger("unique_id", unique_id_);
> +    dict->SetString("type", type_);
>     return dict;
>   }
>
>  private:
>   ~NetLogSpdyPingParameter() {}
>   const uint32 unique_id_;
> +  const std::string type_;
>
>   DISALLOW_COPY_AND_ASSIGN(**NetLogSpdyPingParameter);
>  };
> @@ -1382,7 +1386,8 @@
>  void SpdySession::OnPing(const spdy::SpdyPingControlFrame& frame) {
>   net_log_.AddEvent(
>       NetLog::TYPE_SPDY_SESSION_**PING,
> -      make_scoped_refptr(new NetLogSpdyPingParameter(frame.**
> unique_id())));
> +      make_scoped_refptr(
> +          new NetLogSpdyPingParameter(frame.**unique_id(), "received")));
>
>   // Send response to a PING from server.
>   if (frame.unique_id() % 2 == 0) {
> @@ -1593,7 +1598,7 @@
>   if (net_log().IsLoggingAllEvents(**)) {
>     net_log().AddEvent(
>         NetLog::TYPE_SPDY_SESSION_**PING,
> -        make_scoped_refptr(new NetLogSpdyPingParameter(next_**
> ping_id_)));
> +        make_scoped_refptr(new NetLogSpdyPingParameter(next_**ping_id_,
> "sent")));
>   }
>   if (unique_id % 2 != 0) {
>     next_ping_id_ += 2;
>
>
>

[commit-bot: I haz the power, 2011-12-06 22:14:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/8824005/1

[commit-bot: I haz the power, 2011-12-06 23:46:13]

Change committed as 113295