Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4816)

Unified Diff: chrome/chrome_exe.gypi

Issue 8824003: Breakpad: Compile Breakpad into Chromium by default on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Swap around Gyp options; use mac_breakpad_compiled_in Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_dll.gypi ('k') | chrome/tools/build/mac/tweak_info_plist » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index d2f220666bd52d02cf8bcb5507c3a3335f155acb..80f5679a4bd4a380d99a82243eb942103330b338 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -311,17 +311,18 @@
{
# Modify the Info.plist as needed. The script explains why this
# is needed. This is also done in the helper_app and chrome_dll
- # targets. Use -b0 to not include any Breakpad information; that
- # all goes into the framework's Info.plist. Keystone information
- # is included if Keystone is enabled. The application reads
- # Keystone keys from this plist and not the framework's, and
- # the ticket will reference this Info.plist to determine the tag
- # of the installed product. Use -s1 to include Subversion
- # information. The -p flag controls whether to insert PDF as a
- # supported type identifier that can be opened.
+ # targets. Use --breakpad=0 to not include any Breakpad
+ # information; that all goes into the framework's Info.plist.
+ # Keystone information is included if Keystone is enabled. The
+ # application reads Keystone keys from this plist and not the
+ # framework's, and the ticket will reference this Info.plist to
+ # determine the tag of the installed product. Use -s1 to
+ # include Subversion information. The -p flag controls whether
+ # to insert PDF as a supported type identifier that can be
+ # opened.
'postbuild_name': 'Tweak Info.plist',
'action': ['<(tweak_info_plist_path)',
- '-b0',
+ '--breakpad=0',
'-k<(mac_keystone)',
'-s1',
'-p<(internal_pdf)',
« no previous file with comments | « chrome/chrome_dll.gypi ('k') | chrome/tools/build/mac/tweak_info_plist » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698