Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: build/common.gypi

Issue 8824003: Breakpad: Compile Breakpad into Chromium by default on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Swap around Gyp options; use mac_breakpad_compiled_in Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index ec675c08b77e5a435912d05cb688e398f30b511a..9011072edd47944d02d44b97dc8690375b5879b1 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -720,6 +720,9 @@
['OS=="mac"', {
# Enable clang on mac by default!
'clang%': 1,
+ # Compile in Breakpad support by default so that it can be
+ # tested, even if it is not enabled by default at runtime.
+ 'mac_breakpad_compiled_in%': 1,
'conditions': [
# mac_product_name is set to the name of the .app bundle as it should
# appear on disk. This duplicates data from
@@ -732,13 +735,15 @@
'mac_product_name%': 'Chromium',
}],
- # Feature variables for enabling Mac Breakpad and Keystone auto-update
- # support. Both features are on by default in official builds with
- # Chrome branding.
['branding=="Chrome" and buildtype=="Official"', {
+ # Enable uploading crash dumps.
+ 'mac_breakpad_uploads%': 1,
+ # Enable dumping symbols at build time for use by Mac Breakpad.
'mac_breakpad%': 1,
+ # Enable Keystone auto-update support.
'mac_keystone%': 1,
}, { # else: branding!="Chrome" or buildtype!="Official"
+ 'mac_breakpad_uploads%': 0,
'mac_breakpad%': 0,
'mac_keystone%': 0,
}],
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698