Breakpad: Compile Breakpad into Chromium by default on Mac

chrome/tools/build/mac/tweak_info_plist

 #!/usr/bin/env python
 
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 #
 # Xcode supports build variable substitutions and CPP; sadly, that doesn't work
 # because:
 #
@@ skipping 156 matching lines @@
   # No PDF entry exists. If one needs to be added, do so now.
   if add_keys:
     pdf_entry = {}
     __AddPDFKeys(pdf_entry)
     extensions.append(pdf_entry)
 
 
 def _AddBreakpadKeys(plist, branding):
   """Adds the Breakpad keys. This must be called AFTER _AddVersionKeys() and
   also requires the |branding| argument."""
-  plist['BreakpadURL'] = 'https://clients2.google.com/cr/report'
   plist['BreakpadReportInterval'] = '3600'  # Deliberately a string.
   plist['BreakpadProduct'] = '%s_Mac' % branding
   plist['BreakpadProductDisplay'] = branding
   plist['BreakpadVersion'] = plist['CFBundleShortVersionString']
   # These are both deliberately strings and not boolean.
   plist['BreakpadSendAndExit'] = 'YES'
   plist['BreakpadSkipConfirm'] = 'YES'
 
 
 def _RemoveBreakpadKeys(plist):
@@ skipping 19 matching lines @@
 def _RemoveKeystoneKeys(plist):
   """Removes any set Keystone keys."""
   _RemoveKeys(plist,
       'KSVersion',
       'KSProductID',
       'KSUpdateURL')
 
 
 def Main(argv):
   parser = optparse.OptionParser('%prog [options] branding bundle-id')
-  parser.add_option('-b', dest='use_breakpad', action='store', type='int',
-      default=False, help='Enable Breakpad [1 or 0]')
+  parser.add_option('--breakpad', dest='use_breakpad', action='store',
+      type='int', default=False, help='Enable Breakpad [1 or 0]')
+  parser.add_option('--breakpad_uploads', dest='breakpad_uploads',
+      action='store', type='int', default=False,
+      help='Enable Breakpad\'s uploading of crash dumps [1 or 0]')
   parser.add_option('-k', dest='use_keystone', action='store', type='int',
       default=False, help='Enable Keystone [1 or 0]')
   parser.add_option('-s', dest='add_svn_info', action='store', type='int',
       default=True, help='Add SVN metadata [1 or 0]')
   parser.add_option('-p', dest='add_pdf_support', action='store', type='int',
       default=False, help='Add PDF file handler support [1 or 0]')
   (options, args) = parser.parse_args(argv)
 
   if len(args) < 2:
     print >>sys.stderr, parser.get_usage()
     return 1
 
   # Extract remaining arguments.
   branding = args[0]
   bundle_identifier = args[1]
 
   # Read the plist into its parsed format.
   DEST_INFO_PLIST = os.path.join(env['TARGET_BUILD_DIR'], env['INFOPLIST_PATH'])
   plist = plistlib.readPlist(DEST_INFO_PLIST)
 
   # Insert the product version.
   if not _AddVersionKeys(plist):
     return 2
 
   # Add Breakpad if configured to do so.
   if options.use_breakpad:
     _AddBreakpadKeys(plist, branding)
+    if options.breakpad_uploads:
+      plist['BreakpadURL'] = 'https://clients2.google.com/cr/report'
+    else:
+      # This allows crash dumping to a file without uploading the
+      # dump, for testing purposes.  Breakpad does not recognise
+      # "none" as a special value, but this does stop crash dump
+      # uploading from happening.  We need to specify something
+      # because if "BreakpadURL" is not present, Breakpad will not
+      # register its crash handler and no crash dumping will occur.
+      plist['BreakpadURL'] = 'none'
   else:
     _RemoveBreakpadKeys(plist)
 
   # Only add Keystone in Release builds.
   if options.use_keystone and env['CONFIGURATION'] == 'Release':
     _AddKeystoneKeys(plist, bundle_identifier)
   else:
     _RemoveKeystoneKeys(plist)
 
   # Adds or removes any SVN keys.
   _DoSVNKeys(plist, options.add_svn_info)
 
   # Adds or removes the PDF file handler entry.
   _DoPDFKeys(plist, options.add_pdf_support)
 
   # Now that all keys have been mutated, rewrite the file.
   temp_info_plist = tempfile.NamedTemporaryFile()
   plistlib.writePlist(plist, temp_info_plist.name)
 
   # Info.plist will work perfectly well in any plist format, but traditionally
   # applications use xml1 for this, so convert it to ensure that it's valid.
   proc = subprocess.Popen(['plutil', '-convert', 'xml1', '-o', DEST_INFO_PLIST,
                            temp_info_plist.name])
   proc.wait()
   return proc.returncode
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv[1:]))