Update _OutputPerfGraphValue to handle Chrome.

Update _OutputPerfGraphValue to handle Chrome.
BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113556

[dennis_jeffrey, 2011-12-07 22:25:29]

Just a handful of minor comments.  Thanks a lot!

http://codereview.chromium.org/8824002/diff/3001/functional/perf.py
File functional/perf.py (right):

http://codereview.chromium.org/8824002/diff/3001/functional/perf.py#newcode71
functional/perf.py:71: self.GetBrowserInfo()['properties']['ChromeVersion'])
This is not actually needed right now, until we submit the change that makes use
of it in the buildbot code (and even then, we may ultimately find out that we
don't need this print statement at all).  I recommend we remove this change for
now, until we're sure that we will need it.  If you still want to keep it,
please add a TODO above this line indicating that we need to remember to either
make use of this output value (in the buildbot test output parsing code), or
else remove this statement if it turns out that it's not needed.

http://codereview.chromium.org/8824002/diff/3001/functional/perf.py#newcode125
functional/perf.py:125: 
remove one of these blank lines

http://codereview.chromium.org/8824002/diff/3001/functional/perf.py#newcode158
functional/perf.py:158: graph_name='Default-Graph'):
indent this line by 1 fewer space

http://codereview.chromium.org/8824002/diff/3001/functional/perf.py#newcode169
functional/perf.py:169: units: A string specifying the units for the specified
measurements.
add a description for the new "graph_name" argument

http://codereview.chromium.org/8824002/diff/3001/functional/perf.py#newcode180
functional/perf.py:180: self._OutputPerfGraphValue(description, avg, units,
graph_name)
pass the last argument as a named argument: graph_name=graph_name

http://codereview.chromium.org/8824002/diff/3001/functional/perf.py#newcode380
functional/perf.py:380: self._OutputPerfGraphValue('SunSpider', float(total),
'ms',
please change the first argument to "SunSpider-total", otherwise this will
change the "perf_key" that gets created on ChromeOS.

[chrisphan, 2011-12-07 22:34:13]

http://codereview.chromium.org/8824002/diff/3001/functional/perf.py
File functional/perf.py (right):

http://codereview.chromium.org/8824002/diff/3001/functional/perf.py#newcode71
functional/perf.py:71: self.GetBrowserInfo()['properties']['ChromeVersion'])
On 2011/12/07 22:25:29, dennis_jeffrey wrote:
> This is not actually needed right now, until we submit the change that makes
use
> of it in the buildbot code (and even then, we may ultimately find out that we
> don't need this print statement at all).  I recommend we remove this change
for
> now, until we're sure that we will need it.  If you still want to keep it,
> please add a TODO above this line indicating that we need to remember to
either
> make use of this output value (in the buildbot test output parsing code), or
> else remove this statement if it turns out that it's not needed.

Done.

http://codereview.chromium.org/8824002/diff/3001/functional/perf.py#newcode125
functional/perf.py:125: 
On 2011/12/07 22:25:29, dennis_jeffrey wrote:
> remove one of these blank lines

Done.

http://codereview.chromium.org/8824002/diff/3001/functional/perf.py#newcode158
functional/perf.py:158: graph_name='Default-Graph'):
On 2011/12/07 22:25:29, dennis_jeffrey wrote:
> indent this line by 1 fewer space

Done.

http://codereview.chromium.org/8824002/diff/3001/functional/perf.py#newcode169
functional/perf.py:169: units: A string specifying the units for the specified
measurements.
On 2011/12/07 22:25:29, dennis_jeffrey wrote:
> add a description for the new "graph_name" argument

Done.

http://codereview.chromium.org/8824002/diff/3001/functional/perf.py#newcode180
functional/perf.py:180: self._OutputPerfGraphValue(description, avg, units,
graph_name)
On 2011/12/07 22:25:29, dennis_jeffrey wrote:
> pass the last argument as a named argument: graph_name=graph_name

Done.

http://codereview.chromium.org/8824002/diff/3001/functional/perf.py#newcode380
functional/perf.py:380: self._OutputPerfGraphValue('SunSpider', float(total),
'ms',
On 2011/12/07 22:25:29, dennis_jeffrey wrote:
> please change the first argument to "SunSpider-total", otherwise this will
> change the "perf_key" that gets created on ChromeOS.

Done.

[dennis_jeffrey, 2011-12-07 22:40:40]

LGTM

Awesome - thanks for taking care of this!

[commit-bot: I haz the power, 2011-12-07 22:43:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisphan@chromium.org/8824002/9001

[commit-bot: I haz the power, 2011-12-07 22:43:52]

Presubmit check for 8824002-9001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found line ending with white spaces in:

***************
chrome/test/functional/perf.py, line 463
***************

[commit-bot: I haz the power, 2011-12-07 22:51:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisphan@chromium.org/8824002/10002

[commit-bot: I haz the power, 2011-12-08 02:26:13]

Try job failure for 8824002-10002 (retry) (retry) (previous was lost) on mac_rel
for steps "browser_tests, ui_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2011-12-08 02:42:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisphan@chromium.org/8824002/10002

[commit-bot: I haz the power, 2011-12-08 03:45:25]

Change committed as 113556