Issue 8823019: Mark the leak of bug 77990 as intentional and adjust the suppression

Issue 8823019: Mark the leak of bug 77990 as intentional and adjust the suppression (Closed)

Created:
9 years ago by wtc

Modified:
9 years ago

Reviewers:
cbentzel

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Mark the leak of bug 77990 as intentional and adjust the suppression to be as wide as possible to cover all variants of this leak. Remove the suppression for the leak of bug 95718 because it is a variant of the above leak. R=cbentzel@chromium.org BUG=77990 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113474

Patch Set 1 #

Patch Set 2 : Remove the Mac-specific suppression #

Total comments: 3

Patch Set 3 : Move the suppression to Section 2 (intentional) #

Patch Set 4 : Upload before checkin #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -38 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View	1 2 3	2 chunks	+10 lines, -17 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions_mac.txt	View	1 2 3	1 chunk	+0 lines, -21 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

wtc

http://codereview.chromium.org/8823019/diff/2001/tools/valgrind/memcheck/suppressions_mac.txt File tools/valgrind/memcheck/suppressions_mac.txt (left): http://codereview.chromium.org/8823019/diff/2001/tools/valgrind/memcheck/suppressions_mac.txt#oldcode1765 tools/valgrind/memcheck/suppressions_mac.txt:1765: } I assume suppressions.txt also applies to Mac OS ...

9 years ago (2011-12-07 03:10:48 UTC) #1

cbentzel

http://codereview.chromium.org/8823019/diff/2001/tools/valgrind/memcheck/suppressions.txt File tools/valgrind/memcheck/suppressions.txt (right): http://codereview.chromium.org/8823019/diff/2001/tools/valgrind/memcheck/suppressions.txt#newcode3227 tools/valgrind/memcheck/suppressions.txt:3227: # Intentionally leaking NSS to prevent shutdown crashes This ...

9 years ago (2011-12-07 13:14:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/8823019/11001

9 years ago (2011-12-07 19:43:19 UTC) #5

Change committed as 113474

Expand Messages | Collapse Messages