Issue 8823017: Apparently we're supposed to forward the manifest_version attribute to the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8823017: Apparently we're supposed to forward the manifest_version attribute to the (Closed)

Created:
9 years ago by abarth-chromium

Modified:
9 years ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, jstritar+watch_chromium.org, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Apparently we're supposed to forward the manifest_version attribute to the renderer so it knows how to interpret manifests. BUG=62897 TEST=This is covered by a zillion browser_tests once we make the manifest_version check slightly tighter.

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/common/extensions/extension_messages.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/8823017/1

9 years ago (2011-12-07 00:07:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/8823017/1

9 years ago (2011-12-07 02:52:13 UTC) #4

commit-bot: I haz the power

9 years ago (2011-12-07 02:52:15 UTC) #5

Can't apply patch for file chrome/common/extensions/extension_messages.cc.
While running patch -p0 --forward --force;
patching file chrome/common/extensions/extension_messages.cc
Hunk #1 FAILED at 41.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/common/extensions/extension_messages.cc.rej

Expand Messages | Collapse Messages