Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: tools/clang/plugins/tests/overridden_methods.h

Issue 8823013: One more OVERRIDE test that the code should already pass. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/plugins/tests/overridden_methods.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/overridden_methods.h
diff --git a/tools/clang/plugins/tests/overridden_methods.h b/tools/clang/plugins/tests/overridden_methods.h
index 08ef0a5e4862afcda36cb2f9bbcd446109032f9e..150c79913f1b54181b74b047ea2ba94ce009c076 100644
--- a/tools/clang/plugins/tests/overridden_methods.h
+++ b/tools/clang/plugins/tests/overridden_methods.h
@@ -12,6 +12,7 @@ class BaseClass {
virtual void SomeMethod() = 0;
virtual void SomeOtherMethod() = 0;
virtual void SomeInlineMethod() = 0;
+ virtual void SomeNonPureBaseMethod() {}
};
class InterimClass : public BaseClass {
@@ -46,6 +47,8 @@ class DerivedClass : public InterimClass,
virtual void SomeInlineMethod() {}
// Should not warn if overriding a method whose origin is WebKit.
virtual void WebKitModifiedSomething();
+ // Should warn if overridden method isn't pure.
+ virtual void SomeNonPureBaseMethod() {}
};
#endif // OVERRIDDEN_METHODS_H_
« no previous file with comments | « no previous file | tools/clang/plugins/tests/overridden_methods.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698