Issue 8823012: Prep work for win7-specific condition variable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8823012: Prep work for win7-specific condition variable (Closed)

Created:
9 years ago by cpu_(ooo_6.6-7.5)

Modified:
9 years ago

Reviewers:
brettw, jar (doing other things)

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Prep work for win7-specific condition variable Move windows implementation to pimpl idiom http://c2.com/cgi/wiki?PimplIdiom There should be no behavior change. BUG=none TEST=ConditionVariableTest in base_unittests suffice Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113439

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -97 lines)			Patch
	M	base/synchronization/condition_variable.h	View		3 chunks	+3 lines, -74 lines	0 comments	Download
	M	base/synchronization/condition_variable_win.cc	View		14 chunks	+139 lines, -23 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

The intent here is to use the existing code on XP and use the kernel ...

9 years ago (2011-12-06 22:44:55 UTC) #1

brettw

lgtm http://codereview.chromium.org/8823012/diff/1/base/synchronization/condition_variable_win.cc File base/synchronization/condition_variable_win.cc (right): http://codereview.chromium.org/8823012/diff/1/base/synchronization/condition_variable_win.cc#newcode31 base/synchronization/condition_variable_win.cc:31: // Overridden from ConditionVarImpl. Can you put a ...

9 years ago (2011-12-06 23:44:54 UTC) #2

jar (doing other things)

9 years ago (2011-12-07 07:47:59 UTC) #3

I'm not a big fan of the pimpl pattern... but in this case, getting native
condition variables would probably be a good thing.

LGTM

Expand Messages | Collapse Messages