frog: life is better with colors :)

frog/world.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** The one true [World]. */
 World world;
 
 /**
  * Experimental phase to enable await, only set when using the
  * await/awaitc.dart entrypoint.
@@ skipping 388 matching lines @@
     if (span2 != null) {
       print(span2.toMessageString(message));
     }
 
     if (throwing) {
       throw new CompilerException(message, span);
     }
   }
 
   /** [message] is considered a static compile-time error by the Dart lang. */
-  void error(String message, [SourceSpan span, SourceSpan span1, SourceSpan span2]) {
+  void error(String message,
+      [SourceSpan span, SourceSpan span1, SourceSpan span2]) {
     errors++;
-    _message('error: $message', span, span1, span2, options.throwOnErrors);
+    _message(options.useColors
+        ? '${_RED_COLOR}error$_NO_COLOR: $message' : 'error: $message',

[Bob Nystrom, 2011/12/06 22:47:43]

This seems a bit redundant. How about having _message look at the options itself
so you can just do:

_message(_RED_COLOR, 'error', message, span, span1, span2,
options.throwOnErrors);

[Siggi Cherem (dart-lang), 2011/12/06 23:37:38]

Done.

+        span, span1, span2, options.throwOnErrors);
   }
 
   /** [message] is considered a type warning by the Dart lang. */
-  void warning(String message, [SourceSpan span, SourceSpan span1, SourceSpan span2]) {
+  void warning(String message,
+      [SourceSpan span, SourceSpan span1, SourceSpan span2]) {
     if (options.warningsAsErrors) {
       error(message, span, span1, span2);
       return;
     }
     warnings++;
     if (options.showWarnings) {
-      _message('warning: $message', span, span1, span2, options.throwOnWarnings);
+      _message(options.useColors
+          ? '${_MAGENTA_COLOR}warning$_NO_COLOR: $message'
+          : 'warning: $message', span, span1, span2, options.throwOnWarnings);
     }
   }
 
   /** [message] at [location] is so bad we can't generate runnable code. */
-  void fatal(String message, [SourceSpan span, SourceSpan span1, SourceSpan span2]) {
+  void fatal(String message,
+      [SourceSpan span, SourceSpan span1, SourceSpan span2]) {
     errors++;
     seenFatal = true;
-    _message('fatal: $message', span, span1, span2,
-     options.throwOnFatal || options.throwOnErrors);
+    _message(options.useColors
+        ? '${_RED_COLOR}fatal$_NO_COLOR: $message' : 'fatal: $message',
+        span, span1, span2, options.throwOnFatal || options.throwOnErrors);
   }
 
   /** [message] at [location] is about a bug in the compiler. */
-  void internalError(String message, [SourceSpan span, SourceSpan span1, SourceSpan span2]) {
+  void internalError(String message,
+      [SourceSpan span, SourceSpan span1, SourceSpan span2]) {
     _message('We are sorry, but... $message', span, span1, span2, true);
   }
 
   /**
    * [message] at [location] will tell the user about what the compiler
    * is doing.
    */
   void info(String message, [SourceSpan span, SourceSpan span1, SourceSpan span2]) {
     if (options.showInfo) {
       _message('info: $message', span, span1, span2, false);
@@ skipping 29 matching lines @@
 
   withTiming(String name, f()) {
     final sw = new Stopwatch();
     sw.start();
     var result = f();
     sw.stop();
     info('$name in ${sw.elapsedInMs()}msec');
     return result;
   }
 }