frog: life is better with colors :)

frog/minfrog.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('minfrog');
 
 #import('lib/node/node.dart');
 #import('file_system_node.dart');
 #import('lang.dart');
 
 void main() {
   // Get the home directory from our executable.
   var homedir = path.dirname(fs.realpathSync(process.argv[1]));
 
   // Note: we create a copy of argv here because the one that is passed in is
   // potentially a JS Array object from outside the sandbox. Hence it will have
   // the wrong prototype.
   var argv = new List.from(process.argv);
 
   if (compile(homedir, argv, new NodeFileSystem())) {
+    if (options.outfile !== null) {

[Jennifer Messerly, 2011/12/06 22:50:03]

I won't add this message unless doing "compileOnly"

if you're just running a Dart script, it's important not to output extra stuff.
Imagine if every Python script printed "compilation succeeded" before running :)

so something like:
if (options.compileOnly) {
  // print compilation succeeded message
} else {
  var code = world.getGeneratedCode();
  process.argv = [argv[0], argv[1]];
  // ... vm.runInNewContext ...
}

[Siggi Cherem (dart-lang), 2011/12/06 23:37:38]

The other opinion I heard earlier today was that people wanted to see clearly
when did compilation finished and we started running the actual script (so it is
clear why something failed).

I followed your suggestion for now. Another option is to print this message in 2
scenarios:
- compile only
- compile + run, but outfile was specified.

+      print('Compilation succeded. Code generated in ${options.outfile}');
+    } else {
+      print('Compilation succeded.');
+    }
     var code = world.getGeneratedCode();
     if (!options.compileOnly) {
       process.argv = [argv[0], argv[1]];
       process.argv.addAll(options.childArgs);
       // TODO(jmesserly): we shouldn't force the child process to patch argv.
       // Instead, we should be injecting code into the child to fix argv's
       // prototype (and possible the proto of require, process, and console).
       vm.runInNewContext(code, createSandbox());
     }
   } else {
     process.exit(1);
   }
 }