Remove Hunspell on OS X - step 1

Remove Hunspell on OS X - step 1

This CL removes Hunspell-related options from the spelling context menu on the Mac and tries to bring the menu more inline with the native platform menu.

Notably:
* Spelling submenu observer is split into Hunspell and Mac implementation files.
* strings are split into mac/non-mac variants (saving a bit of space on non-mac platforms?) and the titles are brought more in line with OS X (probably need more work to make this match on all OS X versions).
* Menu is reordered on Mac to more closely match the Cocoa spelling submenu. 

BUG=69944
TEST=Spelling submenu should continue to work on non-Mac platforms. On Mac it should contain 3 items - "Show Spelling and Grammar", "Check Spelling while you Type" and "Language Settings..."


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113457

[Robert Sesek, 2011-12-07 16:21:17]

http://codereview.chromium.org/8823009/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8823009/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:784: <message
name="IDS_CONTENT_CONTEXT_SHOW_SPELLING_PANEL" desc="The name of the Show
Spelling Panel command in the spelling context menu">
Is this string and the string below it really Mac-only? It looks like they
weren't <if>ed before.

http://codereview.chromium.org/8823009/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:791: <if expr="not is_macosx" >
nit: extra space

http://codereview.chromium.org/8823009/diff/1/chrome/browser/tab_contents/spe...
File chrome/browser/tab_contents/spellchecker_submenu_observer.h (right):

http://codereview.chromium.org/8823009/diff/1/chrome/browser/tab_contents/spe...
chrome/browser/tab_contents/spellchecker_submenu_observer.h:49: // Hunspell
spelling submenu
nit: full-stop or :

http://codereview.chromium.org/8823009/diff/1/chrome/browser/tab_contents/spe...
File chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc (right):

http://codereview.chromium.org/8823009/diff/1/chrome/browser/tab_contents/spe...
chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc:7: #include
"base/command_line.h"
Unused?

http://codereview.chromium.org/8823009/diff/1/chrome/browser/tab_contents/spe...
chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc:10: #include
"chrome/browser/browser_process.h"
Unused?

http://codereview.chromium.org/8823009/diff/1/chrome/browser/tab_contents/spe...
chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc:11: #include
"chrome/browser/prefs/pref_member.h"
Unused?

http://codereview.chromium.org/8823009/diff/1/chrome/browser/tab_contents/spe...
chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc:34: {
nit: Join with previous line.

http://codereview.chromium.org/8823009/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/8823009/diff/1/chrome/chrome_browser.gypi#newc...
chrome/chrome_browser.gypi:4394:
'browser/tab_contents/spellchecker_submenu_observer_mac.cc',
Does this need to be pulled out explicitly? I think _mac means that it can be in
the main list of sources and it'll be filtered out automatically.

[jeremy, 2011-12-07 18:28:44]

Ready for another look, thanks!

http://codereview.chromium.org/8823009/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8823009/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:784: <message
name="IDS_CONTENT_CONTEXT_SHOW_SPELLING_PANEL" desc="The name of the Show
Spelling Panel command in the spelling context menu">
The whole platformspellchecker thing is mac only.

http://codereview.chromium.org/8823009/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:791: <if expr="not is_macosx" >
On 2011/12/07 16:21:17, rsesek wrote:
> nit: extra space

Done.

http://codereview.chromium.org/8823009/diff/1/chrome/browser/tab_contents/spe...
File chrome/browser/tab_contents/spellchecker_submenu_observer.h (right):

http://codereview.chromium.org/8823009/diff/1/chrome/browser/tab_contents/spe...
chrome/browser/tab_contents/spellchecker_submenu_observer.h:49: // Hunspell
spelling submenu
On 2011/12/07 16:21:17, rsesek wrote:
> nit: full-stop or :

Done.

http://codereview.chromium.org/8823009/diff/1/chrome/browser/tab_contents/spe...
File chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc (right):

http://codereview.chromium.org/8823009/diff/1/chrome/browser/tab_contents/spe...
chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc:7: #include
"base/command_line.h"
On 2011/12/07 16:21:17, rsesek wrote:
> Unused?

Done.

http://codereview.chromium.org/8823009/diff/1/chrome/browser/tab_contents/spe...
chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc:10: #include
"chrome/browser/browser_process.h"
On 2011/12/07 16:21:17, rsesek wrote:
> Unused?

Done.

http://codereview.chromium.org/8823009/diff/1/chrome/browser/tab_contents/spe...
chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc:11: #include
"chrome/browser/prefs/pref_member.h"
On 2011/12/07 16:21:17, rsesek wrote:
> Unused?

Done.

http://codereview.chromium.org/8823009/diff/1/chrome/browser/tab_contents/spe...
chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc:34: {
On 2011/12/07 16:21:17, rsesek wrote:
> nit: Join with previous line.

Done.

http://codereview.chromium.org/8823009/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/8823009/diff/1/chrome/chrome_browser.gypi#newc...
chrome/chrome_browser.gypi:4394:
'browser/tab_contents/spellchecker_submenu_observer_mac.cc',
On 2011/12/07 16:21:17, rsesek wrote:
> Does this need to be pulled out explicitly? I think _mac means that it can be
in
> the main list of sources and it'll be filtered out automatically.

Done.

[Robert Sesek, 2011-12-07 19:20:44]

lgtm

[commit-bot: I haz the power, 2011-12-07 19:21:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremy@chromium.org/8823009/7001

[commit-bot: I haz the power, 2011-12-07 20:36:57]

Change committed as 113457