Rename file and test to 'chromeos_enterprise_enroll.py' from 'chromeos_enterprise_check_policies'.

Rename file and test to 'chromeos_enterprise_enroll.py' from 'chromeos_enterprise_check_policies'.
The old name was not appropriate for the type of tests being performed, since they have nothing to
do with policies, and everything to do with enrollment.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113349

[xot, 2011-12-06 20:02:33]

Also added new EnrollWithInvalidUsername test. Will not add additional tests
until error reporting is improved (per bug 22280).

[dennis_jeffrey, 2011-12-06 21:41:16]

http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_...
File functional/chromeos_enterprise_enroll.py (right):

http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_...
functional/chromeos_enterprise_enroll.py:10: 
nit: add 1 more blank line here to separate the imports above from the class
below

http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_...
functional/chromeos_enterprise_enroll.py:30:
self.assertFalse(self.IsEnterpriseDevice(), msg='Device is already ' \
I believe the '\' at the end of the line is unnecessary in this case

http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_...
functional/chromeos_enterprise_enroll.py:32: # TODO(scunningham): Add
precondition steps to workaround bug 22282
nit: period at end of sentence

http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_...
functional/chromeos_enterprise_enroll.py:40: return
self._CHROME_FLAGS_FOR_ENTERPRISE
Do we need to also pass along the other default flags for ChromeOS that exist in
pyauto.py's ExtraChromeFlags()?

[xot, 2011-12-06 22:20:41]

Changes made.

http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_...
File functional/chromeos_enterprise_enroll.py (right):

http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_...
functional/chromeos_enterprise_enroll.py:10: 
On 2011/12/06 21:41:16, dennis_jeffrey wrote:
> nit: add 1 more blank line here to separate the imports above from the class
> below

Done.

http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_...
functional/chromeos_enterprise_enroll.py:30:
self.assertFalse(self.IsEnterpriseDevice(), msg='Device is already ' \
On 2011/12/06 21:41:16, dennis_jeffrey wrote:
> I believe the '\' at the end of the line is unnecessary in this case

Done.

http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_...
functional/chromeos_enterprise_enroll.py:32: # TODO(scunningham): Add
precondition steps to workaround bug 22282
On 2011/12/06 21:41:16, dennis_jeffrey wrote:
> nit: period at end of sentence

Done.

http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_...
functional/chromeos_enterprise_enroll.py:40: return
self._CHROME_FLAGS_FOR_ENTERPRISE
On 2011/12/06 21:41:16, dennis_jeffrey wrote:
> Do we need to also pass along the other default flags for ChromeOS that exist
in
> pyauto.py's ExtraChromeFlags()?

No, because no login ever happens.

[dennisjeffrey, 2011-12-06 22:23:19]

Hi Scott,

The code review site doesn't seem to be showing any changes in the latest
patch set.  Did you commit your newest changes locally and then upload to
the code review site?

-Dennis

On Tue, Dec 6, 2011 at 2:20 PM, <scunningham@google.com> wrote:

> Changes made.
>
>
>
> http://codereview.chromium.**org/8823003/diff/1/functional/**
>
chromeos_enterprise_enroll.py<http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_enroll.py>
> File functional/chromeos_**enterprise_enroll.py (right):
>
> http://codereview.chromium.**org/8823003/diff/1/functional/**
>
chromeos_enterprise_enroll.py#**newcode10<http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_enroll.py#newcode10>
> functional/chromeos_**enterprise_enroll.py:10:
> On 2011/12/06 21:41:16, dennis_jeffrey wrote:
>
>> nit: add 1 more blank line here to separate the imports above from the
>>
> class
>
>> below
>>
>
> Done.
>
>
> http://codereview.chromium.**org/8823003/diff/1/functional/**
>
chromeos_enterprise_enroll.py#**newcode30<http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_enroll.py#newcode30>
> functional/chromeos_**enterprise_enroll.py:30:
> self.assertFalse(self.**IsEnterpriseDevice(), msg='Device is already ' \
> On 2011/12/06 21:41:16, dennis_jeffrey wrote:
>
>> I believe the '\' at the end of the line is unnecessary in this case
>>
>
> Done.
>
>
> http://codereview.chromium.**org/8823003/diff/1/functional/**
>
chromeos_enterprise_enroll.py#**newcode32<http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_enroll.py#newcode32>
> functional/chromeos_**enterprise_enroll.py:32: # TODO(scunningham): Add
> precondition steps to workaround bug 22282
> On 2011/12/06 21:41:16, dennis_jeffrey wrote:
>
>> nit: period at end of sentence
>>
>
> Done.
>
>
> http://codereview.chromium.**org/8823003/diff/1/functional/**
>
chromeos_enterprise_enroll.py#**newcode40<http://codereview.chromium.org/8823003/diff/1/functional/chromeos_enterprise_enroll.py#newcode40>
> functional/chromeos_**enterprise_enroll.py:40: return
> self._CHROME_FLAGS_FOR_**ENTERPRISE
> On 2011/12/06 21:41:16, dennis_jeffrey wrote:
>
>> Do we need to also pass along the other default flags for ChromeOS
>>
> that exist in
>
>> pyauto.py's ExtraChromeFlags()?
>>
>
> No, because no login ever happens.
>
>
http://codereview.chromium.**org/8823003/<http://codereview.chromium.org/8823...
>

[xot, 2011-12-06 22:32:22]

This time for real!

[dennis_jeffrey, 2011-12-06 22:40:00]

LGTM - thank you!

[commit-bot: I haz the power, 2011-12-06 22:47:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scunningham@chromium.org/8823003/6001

[commit-bot: I haz the power, 2011-12-06 22:47:24]

Presubmit check for 8823003-6001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
Found line ending with white spaces in:

***************
chrome/test/functional/chromeos_enterprise_enroll.py, line 14
chrome/test/functional/chromeos_enterprise_enroll.py, line 15
chrome/test/functional/chromeos_enterprise_enroll.py, line 16
***************

[commit-bot: I haz the power, 2011-12-07 00:52:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scunningham@chromium.org/8823003/1003

[commit-bot: I haz the power, 2011-12-07 02:52:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scunningham@chromium.org/8823003/1003

[commit-bot: I haz the power, 2011-12-07 05:04:13]

Change committed as 113349