chrome/browser/extensions/installed_loader.cc - Issue 8822021: Revert 113071 - Revert 113047 - Make ExtensionService use ExtensionSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/installed_loader.cc

Issue 8822021: Revert 113071 - Revert 113047 - Make ExtensionService use ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_webrequest_api.cc ('k') | chrome/browser/extensions/network_delay_listener_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/installed_loader.cc

===================================================================

--- chrome/browser/extensions/installed_loader.cc (revision 113231)

+++ chrome/browser/extensions/installed_loader.cc (working copy)

@@ -181,8 +181,8 @@

int theme_count = 0;

int page_action_count = 0;

int browser_action_count = 0;

- const ExtensionList* extensions = extension_service_->extensions();

- ExtensionList::const_iterator ex;

+ const ExtensionSet* extensions = extension_service_->extensions();

+ ExtensionSet::const_iterator ex;

for (ex = extensions->begin(); ex != extensions->end(); ++ex) {

Extension::Location location = (*ex)->location();

Extension::Type type = (*ex)->GetType();

@@ -246,7 +246,7 @@

++browser_action_count;

extension_service_->RecordPermissionMessagesHistogram(

- ex->get(), "Extensions.Permissions_Load");

+ *ex, "Extensions.Permissions_Load");

}

UMA_HISTOGRAM_COUNTS_100("Extensions.LoadApp",

app_user_count + app_external_count);