Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: chrome/browser/extensions/extension_override_apitest.cc

Issue 8822021: Revert 113071 - Revert 113047 - Make ExtensionService use ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_override_apitest.cc
===================================================================
--- chrome/browser/extensions/extension_override_apitest.cc (revision 113231)
+++ chrome/browser/extensions/extension_override_apitest.cc (working copy)
@@ -114,15 +114,16 @@
// Regression test for http://crbug.com/41442.
IN_PROC_BROWSER_TEST_F(ExtensionOverrideTest, ShouldNotCreateDuplicateEntries) {
- ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("override/history")));
+ const Extension* extension =
+ LoadExtension(test_data_dir_.AppendASCII("override/history"));
+ ASSERT_TRUE(extension);
// Simulate several LoadExtension() calls happening over the lifetime of
// a preferences file without corresponding UnloadExtension() calls.
for (size_t i = 0; i < 3; ++i) {
ExtensionWebUI::RegisterChromeURLOverrides(
browser()->profile(),
- browser()->profile()->GetExtensionService()->extensions()->back()->
- GetChromeURLOverrides());
+ extension->GetChromeURLOverrides());
}
ASSERT_TRUE(CheckHistoryOverridesContainsNoDupes());
@@ -160,8 +161,9 @@
}
// Load the failing version. This should take precedence.
- ASSERT_TRUE(LoadExtension(
- test_data_dir_.AppendASCII("override").AppendASCII("keyboard_fails")));
+ const Extension* extension = LoadExtension(
+ test_data_dir_.AppendASCII("override").AppendASCII("keyboard_fails"));
+ ASSERT_TRUE(extension);
{
ResultCatcher catcher;
NavigateToKeyboard();
@@ -169,9 +171,7 @@
}
// Unload the failing version. We should be back to passing now.
- const ExtensionList *extensions =
- browser()->profile()->GetExtensionService()->extensions();
- UnloadExtension((*extensions->rbegin())->id());
+ UnloadExtension(extension->id());
{
ResultCatcher catcher;
NavigateToKeyboard();
« no previous file with comments | « chrome/browser/extensions/extension_management_browsertest.cc ('k') | chrome/browser/extensions/extension_preference_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698