Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 8822020: roll gyp 1101:1103 (Closed)

Created:
9 years ago by Nico
Modified:
9 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

roll gyp 1101:1103 1102: Lots of python style cleanups; let gyp-mac-tool use `/usr/bin/env python`. 1103: Add pylint presubmit check. BUG=none TEST=none TBR=mark Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
I wanted to change the shebang line of mactool, but maruel already did this – ...
9 years ago (2011-12-06 17:46:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8822020/1
9 years ago (2011-12-06 17:46:15 UTC) #2
Mark Mentovai
LGTM
9 years ago (2011-12-06 17:56:33 UTC) #3
commit-bot: I haz the power
Try job failure for 8822020-1 (retry) (retry) on mac_rel for step "ui_tests" (clobber build). It's ...
9 years ago (2011-12-06 20:43:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8822020/1
9 years ago (2011-12-06 20:43:43 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-06 23:24:03 UTC) #6
Change committed as 113272

Powered by Google App Engine
This is Rietveld 408576698