Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 8822019: Reapply r10158: Distinguish weak references in heap snapshots, group GC roots. (Closed)

Created:
9 years ago by mnaganov (inactive)
Modified:
9 years ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Reapply r10158: Distinguish weak references in heap snapshots, group GC roots. [Fixed the bug revealed by the Win32 bot] Several changes to better organize snapshot data: 1. Provide information about weak references. 2. Group (GC roots) children. 3. Prettify debug snapshot printing. BUG=v8:1832 TEST=cctest/test-heap-profiler/*Weak* TBR=vitalyr@chromium.org Initial CL: http://codereview.chromium.org/8716009 Committed: http://code.google.com/p/v8/source/detail?r=10182

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -58 lines) Patch
M include/v8-profiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 4 chunks +13 lines, -13 lines 0 comments Download
M src/objects.h View 2 chunks +30 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/profile-generator.h View 10 chunks +27 lines, -4 lines 0 comments Download
M src/profile-generator.cc View 20 chunks +214 lines, -28 lines 0 comments Download
M src/profile-generator-inl.h View 1 chunk +19 lines, -0 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 3 chunks +96 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
mnaganov (inactive)
9 years ago (2011-12-06 17:41:02 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698