Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: chrome/browser/sync/engine/resolve_conflicts_command.cc

Issue 8822018: [Sync] Set HasCustomGroupsToChange() to true for ResolveConflictsCommand (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/engine/resolve_conflicts_command.h" 5 #include "chrome/browser/sync/engine/resolve_conflicts_command.h"
6 6
7 #include "chrome/browser/sync/engine/conflict_resolver.h" 7 #include "chrome/browser/sync/engine/conflict_resolver.h"
8 #include "chrome/browser/sync/sessions/session_state.h" 8 #include "chrome/browser/sync/sessions/session_state.h"
9 #include "chrome/browser/sync/sessions/sync_session.h" 9 #include "chrome/browser/sync/sessions/sync_session.h"
10 #include "chrome/browser/sync/syncable/directory_manager.h" 10 #include "chrome/browser/sync/syncable/directory_manager.h"
11 11
12 namespace browser_sync { 12 namespace browser_sync {
13 13
14 ResolveConflictsCommand::ResolveConflictsCommand() {} 14 ResolveConflictsCommand::ResolveConflictsCommand() {}
15 ResolveConflictsCommand::~ResolveConflictsCommand() {} 15 ResolveConflictsCommand::~ResolveConflictsCommand() {}
16 16
17 bool ResolveConflictsCommand::HasCustomGroupsToChange() const { 17 bool ResolveConflictsCommand::HasCustomGroupsToChange() const {
18 // TODO(akalin): Set to true. 18 return true;
19 return false;
20 } 19 }
21 20
22 std::set<ModelSafeGroup> ResolveConflictsCommand::GetGroupsToChange( 21 std::set<ModelSafeGroup> ResolveConflictsCommand::GetGroupsToChange(
23 const sessions::SyncSession& session) const { 22 const sessions::SyncSession& session) const {
24 return session.GetEnabledGroupsWithConflicts(); 23 return session.GetEnabledGroupsWithConflicts();
25 } 24 }
26 25
27 void ResolveConflictsCommand::ModelChangingExecuteImpl( 26 void ResolveConflictsCommand::ModelChangingExecuteImpl(
28 sessions::SyncSession* session) { 27 sessions::SyncSession* session) {
29 ConflictResolver* resolver = session->context()->resolver(); 28 ConflictResolver* resolver = session->context()->resolver();
30 DCHECK(resolver); 29 DCHECK(resolver);
31 if (!resolver) 30 if (!resolver)
32 return; 31 return;
33 32
34 syncable::ScopedDirLookup dir(session->context()->directory_manager(), 33 syncable::ScopedDirLookup dir(session->context()->directory_manager(),
35 session->context()->account_name()); 34 session->context()->account_name());
36 if (!dir.good()) 35 if (!dir.good())
37 return; 36 return;
38 sessions::StatusController* status = session->mutable_status_controller(); 37 sessions::StatusController* status = session->mutable_status_controller();
39 const sessions::ConflictProgress* progress = status->conflict_progress(); 38 const sessions::ConflictProgress* progress = status->conflict_progress();
40 if (!progress) 39 if (!progress)
41 return; // Nothing to do. 40 return; // Nothing to do.
42 status->update_conflicts_resolved( 41 status->update_conflicts_resolved(
43 resolver->ResolveConflicts(dir, *progress, status)); 42 resolver->ResolveConflicts(dir, *progress, status));
44 } 43 }
45 44
46 } // namespace browser_sync 45 } // namespace browser_sync
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698