Issue 8822017: [Sync] Set HasCustomGroupsToChange() to true for ProcessUpdatesCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8822017: [Sync] Set HasCustomGroupsToChange() to true for ProcessUpdatesCommand (Closed)

Created:
9 years ago by akalin

Modified:
9 years ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Set HasCustomGroupsToChange() to true for ProcessUpdatesCommand Follow-up to 113090 to see which ModelChangingSyncerCommand triggers a perf regression. BUG=97832 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114090 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114485

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/sync/engine/process_updates_command.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

akalin

On 2011/12/06 17:25:38, akalin wrote: > +tim for review (although I may TBR this) Note ...

9 years ago (2011-12-06 17:26:04 UTC) #2

akalin

9 years ago (2011-12-13 00:48:09 UTC) #4

On 2011/12/07 04:37:55, timsteele wrote:
> lgtm

This seems to have regressed both delete_typed_urls and some autofill profiles
stuff:
http://build.chromium.org/f/chromium/perf/mac-release-10.6/sync/report.html?h...

Expand Messages | Collapse Messages